Skip to content

chore(deps): align ESLint 10 upgrade - #24

Merged
seonghobae merged 5 commits into
developfrom
deps/eslint10-alignment
Mar 11, 2026
Merged

chore(deps): align ESLint 10 upgrade#24
seonghobae merged 5 commits into
developfrom
deps/eslint10-alignment

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Summary

  • replace the failing ESLint 10 Dependabot PR with a repo-owned branch
  • add the explicit @eslint/js dependency required by the current flat config
  • preserve the ESLint 10 upgrade while keeping the rest of the lint stack unchanged

Supersedes

Verification

  • ./scripts/harness/quickcheck.sh

dependabot Bot and others added 2 commits March 11, 2026 05:56
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.4 to 10.0.3.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v9.39.4...v10.0.3)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.0.3
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a4252b1b-7842-466f-8980-cae25a9c59c1

📥 Commits

Reviewing files that changed from the base of the PR and between 1b1b891 and 3b4697c.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • apps/desktop/package.json
  • package.json

📝 Walkthrough

Summary by CodeRabbit

릴리스 노트

  • Chores
    • 개발 도구 의존성을 업데이트했습니다. 여러 패키지에서 코드 검사 도구를 최신 버전으로 업그레이드하고 관련 패키지를 추가했습니다.

Walkthrough

루트와 일부 패키지의 ESLint 관련 의존성이 업데이트되었습니다: apps/desktoppackages/shared-types에서 eslint가 ^9.22.0에서 ^10.0.3으로 변경되었고, 루트 package.jsondevDependencies@eslint/js ^10.0.1이 추가되었습니다. 기능적 변화는 없습니다.

Changes

Cohort / File(s) Summary
ESLint 메이저 버전 업그레이드
apps/desktop/package.json, packages/shared-types/package.json
eslint 버전을 ^9.22.0에서 ^10.0.3으로 업데이트
루트 devDependency 추가
package.json
루트 package.jsondevDependencies@eslint/js ^10.0.1 추가

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 깡충깡충, 린터가 높아졌네
새 버전 달아 반짝이네 ✨
설정은 그대로, 흐름은 동일
작은 변경, 안심의 한숨
토끼가 당근으로 축하하네 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: aligning an ESLint 10 upgrade across multiple package.json files in the repository.
Description check ✅ Passed The description is directly related to the changeset, explaining why ESLint versions are being bumped and what additional dependency was added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch deps/eslint10-alignment

Comment @coderabbitai help to get the list of available commands and usage tips.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@seonghobae
seonghobae enabled auto-merge March 11, 2026 06:01
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai pause

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai resume

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Around line 30-31: devDependencies에 추가한 "@eslint/js"의 버전 불일치를 정리하세요: 현재
워크스페이스의 eslint가 "^10.0.3"이므로 package.json의 devDependencies에 있는 "@eslint/js"를
"^10.0.3"으로 업데이트해 일관성 있게 맞추고 워크스페이스 전체에서 동일한 ESLint 버전 조합이 사용되도록 하세요 (참고 심볼:
"devDependencies" 섹션의 "@eslint/js").

In `@packages/shared-types/package.json`:
- Line 14: The project is using ESLint v10 but `@typescript-eslint` packages are
still at an incompatible v8.26.1; update `@typescript-eslint/eslint-plugin`,
`@typescript-eslint/parser` and `@typescript-eslint/utils` in package.json to at
least ^8.56.0 (or a newer v8 that declares ESLint 10 support), then reinstall
dependencies (npm/yarn/pnpm) and regenerate the lockfile; finally run the linter
(eslint) and fix any rule changes or type errors introduced by the upgraded
`@typescript-eslint` packages.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f8b73b5a-d832-4cb0-abc5-7dc1bd684585

📥 Commits

Reviewing files that changed from the base of the PR and between e1b97a8 and 9a1b29f.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • apps/desktop/package.json
  • package.json
  • packages/shared-types/package.json

Comment thread package.json Outdated
Comment thread packages/shared-types/package.json
@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Reviews paused.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Reviews resumed.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai pause

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai resume

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai resolve

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/desktop/package.json`:
- Around line 25-29: The package.json currently pins "typescript-eslint":
"^8.26.1", which is incompatible with ESLint 10; update that dependency to a
version that adds ESLint 10 support (use ^8.57.0 or newer) so it matches the
upgraded "eslint": "^10.0.3". Locate the dependency entry for
"typescript-eslint" in the apps/desktop package.json and change its version
range to ^8.57.0 (or a later 8.x that documents ESLint 10 support), then run
your install/lockfile update (npm/yarn/pnpm) to regenerate lockfiles and verify
linting passes.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 35ef375d-822d-45e2-bfe5-738dd3eb3bec

📥 Commits

Reviewing files that changed from the base of the PR and between 9a1b29f and 1b1b891.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • apps/desktop/package.json
  • packages/shared-types/package.json

Comment thread apps/desktop/package.json
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Reviews paused.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Reviews resumed.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Comments resolved and changes approved.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai pause

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai resume

@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai resolve

@seonghobae
seonghobae merged commit d9e1609 into develop Mar 11, 2026
16 checks passed
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Reviews resumed.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Reviews paused.

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Comments resolved and changes approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant