chore(deps): align ESLint 10 upgrade - #24
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.4 to 10.0.3. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.4...v10.0.3) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.0.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit릴리스 노트
Walkthrough루트와 일부 패키지의 ESLint 관련 의존성이 업데이트되었습니다: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai pause |
|
@coderabbitai resume |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Around line 30-31: devDependencies에 추가한 "@eslint/js"의 버전 불일치를 정리하세요: 현재
워크스페이스의 eslint가 "^10.0.3"이므로 package.json의 devDependencies에 있는 "@eslint/js"를
"^10.0.3"으로 업데이트해 일관성 있게 맞추고 워크스페이스 전체에서 동일한 ESLint 버전 조합이 사용되도록 하세요 (참고 심볼:
"devDependencies" 섹션의 "@eslint/js").
In `@packages/shared-types/package.json`:
- Line 14: The project is using ESLint v10 but `@typescript-eslint` packages are
still at an incompatible v8.26.1; update `@typescript-eslint/eslint-plugin`,
`@typescript-eslint/parser` and `@typescript-eslint/utils` in package.json to at
least ^8.56.0 (or a newer v8 that declares ESLint 10 support), then reinstall
dependencies (npm/yarn/pnpm) and regenerate the lockfile; finally run the linter
(eslint) and fix any rule changes or type errors introduced by the upgraded
`@typescript-eslint` packages.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f8b73b5a-d832-4cb0-abc5-7dc1bd684585
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
apps/desktop/package.jsonpackage.jsonpackages/shared-types/package.json
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
✅ Actions performedReviews paused. |
✅ Actions performedReviews resumed. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai pause |
|
@coderabbitai resume |
|
@coderabbitai resolve |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/desktop/package.json`:
- Around line 25-29: The package.json currently pins "typescript-eslint":
"^8.26.1", which is incompatible with ESLint 10; update that dependency to a
version that adds ESLint 10 support (use ^8.57.0 or newer) so it matches the
upgraded "eslint": "^10.0.3". Locate the dependency entry for
"typescript-eslint" in the apps/desktop package.json and change its version
range to ^8.57.0 (or a later 8.x that documents ESLint 10 support), then run
your install/lockfile update (npm/yarn/pnpm) to regenerate lockfiles and verify
linting passes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 35ef375d-822d-45e2-bfe5-738dd3eb3bec
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
apps/desktop/package.jsonpackages/shared-types/package.json
✅ Actions performedReviews paused. |
✅ Actions performedReviews resumed. |
✅ Actions performedComments resolved and changes approved. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai pause |
|
@coderabbitai resume |
|
@coderabbitai resolve |
✅ Actions performedReviews resumed. |
✅ Actions performedReviews paused. |
✅ Actions performedComments resolved and changes approved. |
Summary
@eslint/jsdependency required by the current flat configSupersedes
Verification