build(deps-dev): bump eslint from 10.7.0 to 10.8.0 - #757
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 10.7.0 to 10.8.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.7.0...v10.8.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.8.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesESLint 버전 갱신
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head35e339ac62f4eba7894982ff51f507c05f8cdcf3. -
Head SHA:
35e339ac62f4eba7894982ff51f507c05f8cdcf3 -
Workflow run: 31049817782
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
|
|
@coderabbitai review Review the exact live head only. Verify ESLint 10.8.0 and the lockfile remain compatible with every configured plugin/parser, no rule behavior is silently disabled, the quadratic-regex fix is present through the resolved version, and lint, strict typecheck, complete tests/coverage, builds, audit, and security gates pass. Review only; do not update the branch, merge, release, or alter protections. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== PR metadata and exact head ==='
gh pr view 757 --repo ContextualWisdomLab/bandscope \
--json number,url,headRefName,headRefOid,baseRefName,files,statusCheckRollup \
--jq '{number,url,headRefName,headRefOid,baseRefName,files:[.files[].path],statusCheckRollup}'
echo
echo '=== Working-tree commit and PR diff ==='
git rev-parse HEAD
git status --short
git diff --name-status "origin/$(gh pr view 757 --repo ContextualWisdomLab/bandscope --json baseRefName --jq .baseRefName)...HEAD"
echo
echo '=== Root workspace files ==='
fd -HI -d 3 -t f \
'^(package\.json|package-lock\.json|npm-shrinkwrap\.json|pnpm-lock\.yaml|yarn\.lock|bun\.lockb|eslint\.config\..*|\.eslintrc.*|turbo\.json)$' . \
| sort
echo
echo '=== Package-manager and quality-gate scripts ==='
if [ -f package.json ]; then
jq '{packageManager,engines,workspaces,scripts,devDependencies,dependencies,overrides,resolutions}' package.json
fi
for file in apps/desktop/package.json packages/shared-types/package.json; do
if [ -f "$file" ]; then
echo "--- $file"
jq '{packageManager,engines,scripts,devDependencies,dependencies,peerDependencies,overrides,resolutions}' "$file"
fi
done
echo
echo '=== ESLint configurations and configured integrations ==='
fd -HI -t f '^(eslint\.config\..*|\.eslintrc.*)$' . -E node_modules -E .git | sort | while IFS= read -r file; do
echo "--- $file"
sed -n '1,260p' "$file"
done
printf '\n--- ESLint/parser/plugin declarations and rules ---\n'
rg -n -i -C 3 \
'(`@eslint/`|eslint-plugin-|typescript-eslint|`@typescript-eslint/parser`|parser\s*:|plugins\s*:|rules\s*:|eslintConfig)' \
-g 'package.json' -g 'eslint.config.*' -g '.eslintrc*' . \
-g '!node_modules' -g '!.git' || true
echo
echo '=== Lockfile ESLint, plugin/parser, and quadratic-regex resolution ==='
for lock in package-lock.json npm-shrinkwrap.json pnpm-lock.yaml yarn.lock; do
if [ -f "$lock" ]; then
echo "--- $lock"
rg -n -i -C 3 \
'(^\s{0,4}(eslint|`@eslint/`[^:]+|eslint-plugin-[^\s:]+|`@typescript-eslint/parser`|typescript-eslint|quadratic-regex)(@|:|\s)|quadratic-regex)' \
"$lock" || true
fi
done
echo
echo '=== Dependency update diff ==='
git diff --unified=80 "origin/$(gh pr view 757 --repo ContextualWisdomLab/bandscope --json baseRefName --jq .baseRefName)...HEAD" \
-- apps/desktop/package.json packages/shared-types/package.json package-lock.json npm-shrinkwrap.json pnpm-lock.yaml yarn.lock || true
echo
echo '=== Workflow quality/security jobs ==='
fd -HI -t f -d 3 '.*\.(yml|yaml)$' .github 2>/dev/null | sort | while IFS= read -r file; do
echo "--- $file"
rg -n -i -C 3 \
'(eslint|lint|typecheck|type-check|test|coverage|build|audit|security|codeql|dependency-review|npm ci|pnpm install|yarn install)' \
"$file" || true
done
echo
echo '=== Exact-head check suites and check runs ==='
head_sha="$(gh pr view 757 --repo ContextualWisdomLab/bandscope --json headRefOid --jq .headRefOid)"
gh api "repos/ContextualWisdomLab/bandscope/commits/${head_sha}/check-suites?per_page=100" \
--paginate \
--jq '.check_suites[] | {app:.app.slug,status,conclusion,head_sha,workflow_run:.workflow_run}'
gh api "repos/ContextualWisdomLab/bandscope/commits/${head_sha}/check-runs?per_page=100" \
--paginate \
--jq '.check_runs[] | {name,status,conclusion,details_url,started_at,completed_at}'Length of output: 110000 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ContextualWisdomLab/bandscope"
job_id="92074489522"
echo '=== Failed security-audit job metadata and failed-step log ==='
gh api "repos/${repo}/actions/jobs/${job_id}" \
--jq '{name,status,conclusion,started_at,completed_at,html_url,steps:[.steps[]|{name,status,conclusion,number}]}'
gh run view 30933726896 --repo "$repo" --job "$job_id" --log-failed
echo
echo '=== Complete resolved ESLint integration graph in package-lock.json ==='
jq -r '
.packages
| to_entries[]
| select(
(.key | test("(^|/)(eslint|`@eslint/`[^/]+|eslint-plugin-[^/]+|typescript-eslint|`@typescript-eslint/`(parser|eslint-plugin))$"))
)
| [
.key,
(.value.version // ""),
((.value.peerDependencies // {}) | tojson),
((.value.engines // {}) | tojson)
]
| `@tsv`
' package-lock.json | sort
echo
echo '=== ESLint 10.8.0 packages, including all workspace-local copies ==='
jq -r '
.packages
| to_entries[]
| select(.value.name == "eslint" or (.key | test("(^|/)eslint$")))
| [.key, (.value.version // ""), (.value.resolved // ""), ((.value.dependencies // {}) | tojson)]
| `@tsv`
' package-lock.json | sort
echo
echo '=== Any resolved quadratic-regex package ==='
jq -r '
.packages
| to_entries[]
| select(.key | test("(^|/)quadratic-regex$"))
| [.key, (.value.version // ""), (.value.resolved // ""), (.value.integrity // "")]
| `@tsv`
' package-lock.json
echo
echo '=== Workspace lockfile consistency ==='
jq -e '
.packages["apps/desktop"].devDependencies.eslint == "^10.8.0"
and .packages["packages/shared-types"].devDependencies.eslint == "^10.8.0"
and ([.packages | to_entries[] | select(.key | test("^(apps/desktop|packages/shared-types)/node_modules/eslint$")) | .[].value.version] | all(. == "10.8.0"))
' package-lock.jsonLength of output: 40869 🤖 web_search executed:
Length of output: 2845 🏁 Script executed: #!/bin/bash
set -euo pipefail
base_ref="$(gh pr view 757 --repo ContextualWisdomLab/bandscope --json baseRefName --jq .baseRefName)"
echo '=== Current lockfile: undici package entries and reverse dependencies ==='
jq -r '
.packages
| to_entries[]
| select(.key | test("(^|/)undici$"))
| [.key, (.value.version // ""), (.value.resolved // ""), ((.value.dependencies // {}) | tojson)]
| `@tsv`
' package-lock.json
jq -r '
.packages
| to_entries[]
| select((.value.dependencies // {} | has("undici")) or (.value.optionalDependencies // {} | has("undici")))
| [.key, (.value.version // ""), ((.value.dependencies.undici // .value.optionalDependencies.undici) // "")]
| `@tsv`
' package-lock.json | sort
echo
echo '=== Base-lockfile: undici package entries and reverse dependencies ==='
git show "origin/${base_ref}:package-lock.json" > /tmp/base-package-lock.json
jq -r '
.packages
| to_entries[]
| select(.key | test("(^|/)undici$"))
| [.key, (.value.version // ""), (.value.resolved // ""), ((.value.dependencies // {}) | tojson)]
| `@tsv`
' /tmp/base-package-lock.json
jq -r '
.packages
| to_entries[]
| select((.value.dependencies // {} | has("undici")) or (.value.optionalDependencies // {} | has("undici")))
| [.key, (.value.version // ""), ((.value.dependencies.undici // .value.optionalDependencies.undici) // "")]
| `@tsv`
' /tmp/base-package-lock.json | sort
echo
echo '=== Lockfile consistency and workspace-local ESLint binaries ==='
jq -e '
(.packages["apps/desktop"].devDependencies.eslint == "^10.8.0")
and (.packages["packages/shared-types"].devDependencies.eslint == "^10.8.0")
and (
[
.packages["apps/desktop/node_modules/eslint"].version,
.packages["packages/shared-types/node_modules/eslint"].version
]
| all(. == "10.8.0")
)
' package-lock.json
echo
echo '=== Workspace script dispatch and npm bin behavior ==='
npm pkg get scripts.lint --workspace `@bandscope/desktop`
npm pkg get scripts.lint --workspace `@bandscope/shared-types`
npm explain eslint --workspace `@bandscope/desktop` || true
npm explain eslint --workspace `@bandscope/shared-types` || true
echo
echo '=== Exact-head CI logs: lint, typecheck, test, coverage, and build evidence ==='
for run in 30933729247 30933727016; do
echo "--- workflow run ${run}"
gh run view "$run" --repo ContextualWisdomLab/bandscope --log \
| rg -n -i -C 2 \
'(npm run (lint|typecheck|test|build|check)|lint:|typecheck|vitest|coverage|test(s)? passed|build frontend|build-and-test|quickcheck|error|failed)' \
|| true
done
echo
echo '=== Static map of harness commands referenced by passing workflows ==='
ast-grep outline scripts --items all --type function --match 'main|run|check' 2>/dev/null || true
for file in scripts/harness/quickcheck.sh scripts/checks/run_root_tests.mjs; do
if [ -f "$file" ]; then
echo "--- ${file}"
sed -n '1,260p' "$file"
fi
doneLength of output: 126185
ESLint and lockfile
Quality gates
Security gate status
GitHub associated the checks with the PR head. The workflows tested GitHub’s generated PR merge commit No PR-introduced ESLint compatibility or lockfile defect was found. The existing failed audit gate remains unresolved. You are interacting with an AI system. |
Bumps eslint from 10.7.0 to 10.8.0.
Release notes
Sourced from eslint's releases.
Commits
749dfed10.8.04bd0d75Build: changelog update for 10.8.04fbf46dtest: pinwebpackversion to 5.108.4 (#21137)6ddf858docs: fix broken Specify Parser Options anchor link (#21106)784dfbedocs: Clarifyno-eq-nulldescription (#21120)6b8d2f7fix: escape reserved characters in rule id inhtmlformatter (#21129)2d063e2chore: update HTTP URLs to HTTPS in JSDoc and comments (#21101)eccbe7btest: add error locations tono-class-assign(#21123)2fee9bbfeat: exportConfigObjectfromeslint/config(#21082)e7d1e43ci: bump actions/setup-go from 6 to 7 (#21118)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by CodeRabbit