π¨ Palette: μ 보 λ·°μ΄ μμ΄μ½ λ²νΌ ν΄ν μΆκ° - #691
π¨ Palette: μ
보 λ·°μ΄ μμ΄μ½ λ²νΌ ν΄ν μΆκ°#691seonghobae wants to merge 4 commits into
Conversation
λ§μ°μ€ μ¬μ©μλ€μ μ¬μ©μ±μ κ°μ νκΈ° μν΄ ν μ€νΈ μμ΄ μμ΄μ½λ§ μλ λ²νΌμ `title` μμ±μ μΆκ°νμ¬ λ€μ΄ν°λΈ λΈλΌμ°μ ν΄νμ΄ νμλλλ‘ νμ΅λλ€. (ScoreView λ° ScoreViewer μ»΄ν¬λνΈ)
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
Adds native browser tooltips (title) to icon(-heavy) controls in the desktop score UI so mouse users can discover actions via hover text while keeping existing aria-label accessibility intact.
Changes:
- Added
titleattributes to ScoreViewer navigation/zoom/fit controls using existing i18n keys. - Added a
titleattribute to the score attachment βremoveβ icon button, including the filename for clarity.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/desktop/src/features/score/ScoreViewer.tsx | Adds title tooltips to zoom/fit/page navigation buttons via existing translations. |
| apps/desktop/src/features/score/ScoreView.tsx | Adds a title tooltip to the attachment remove icon button (includes filename). |
Comments suppressed due to low confidence (1)
apps/desktop/src/features/score/ScoreViewer.tsx:314
- Same issue for the next-page icon: when
disabledat the end of the document, thetitletooltip usually wonβt show. A wrapper element with the sametitlepreserves the tooltip even when the button is disabled.
className="size-14"
aria-label={t("scoreViewerNextPage")}
title={t("scoreViewerNextPage")}
disabled={pageNumber >= pageCount}
onClick={goToNextPage}
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| className="size-14" | ||
| aria-label={t("scoreViewerPrevPage")} | ||
| title={t("scoreViewerPrevPage")} | ||
| disabled={pageNumber <= 1} | ||
| onClick={goToPreviousPage} |
| disabled={!projectId} | ||
| aria-label={`${t("scoreRemove")}: ${attachment.fileName}`} | ||
| title={`${t("scoreRemove")}: ${attachment.fileName}`} | ||
| className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10" | ||
| > |
λ§μ°μ€ μ¬μ©μλ€μ μ¬μ©μ±μ κ°μ νκΈ° μν΄ ν μ€νΈ μμ΄ μμ΄μ½λ§ μλ λ²νΌμ `title` μμ±μ μΆκ°νμ¬ λ€μ΄ν°λΈ λΈλΌμ°μ ν΄νμ΄ νμλλλ‘ νμ΅λλ€. (ScoreView λ° ScoreViewer μ»΄ν¬λνΈ)
λ§μ°μ€ μ¬μ©μλ€μ μ¬μ©μ±μ κ°μ νκΈ° μν΄ ν μ€νΈ μμ΄ μμ΄μ½λ§ μλ λ²νΌμ `title` μμ±μ μΆκ°νμ¬ λ€μ΄ν°λΈ λΈλΌμ°μ ν΄νμ΄ νμλλλ‘ νμ΅λλ€. (ScoreView λ° ScoreViewer μ»΄ν¬λνΈ) μΆκ°λ‘ Trivy 보μ κ°μ¬λ₯Ό ν΅κ³ΌνκΈ° μν΄ analysis-engineμ setuptools λ²μ μ 71.1.0 μ΄μμΌλ‘ μ λ°μ΄νΈνκ³ , νλ‘ νΈμλμ brace-expansion μ·¨μ½μ μ npm audit fixλ‘ ν΄κ²°νμ΅λλ€.
| "numpy>=1.26", | ||
| "setuptools>=71.1.0", | ||
| "soundfile>=0.13.1", |
λ§μ°μ€ μ¬μ©μλ€μ μ¬μ©μ±μ κ°μ νκΈ° μν΄ ν μ€νΈ μμ΄ μμ΄μ½λ§ μλ λ²νΌμ `title` μμ±μ μΆκ°νμ¬ λ€μ΄ν°λΈ λΈλΌμ°μ ν΄νμ΄ νμλλλ‘ νμ΅λλ€. (ScoreView λ° ScoreViewer μ»΄ν¬λνΈ) μΆκ°λ‘ Trivy 보μ κ°μ¬λ₯Ό ν΅κ³ΌνκΈ° μν΄ analysis-engineμ setuptools λ²μ μ 71.1.0 μ΄μμΌλ‘ μ λ°μ΄νΈνκ³ , νλ‘ νΈμλμ brace-expansion μ·¨μ½μ μ npm audit fixλ‘ ν΄κ²°νμ΅λλ€.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (4)
apps/desktop/src/features/score/ScoreViewer.tsx:301
titletooltips generally do not appear on disabled<button>elements in browsers. Since this control is sometimes disabled (pageNumber <= 1), mouse users wonβt see the tooltip in that state. Consider wrapping the button in an element with thetitleand making the disabled button ignore pointer events so the wrapper can show the tooltip.
aria-label={t("scoreViewerPrevPage")}
title={t("scoreViewerPrevPage")}
disabled={pageNumber <= 1}
onClick={goToPreviousPage}
>
apps/desktop/src/features/score/ScoreViewer.tsx:315
titletooltips generally do not appear on disabled<button>elements in browsers. Since this control is sometimes disabled (pageNumber >= pageCount), mouse users wonβt see the tooltip in that state. Consider wrapping the button in an element with thetitleand making the disabled button ignore pointer events so the wrapper can show the tooltip.
aria-label={t("scoreViewerNextPage")}
title={t("scoreViewerNextPage")}
disabled={pageNumber >= pageCount}
onClick={goToNextPage}
>
apps/desktop/src/features/score/ScoreView.tsx:202
titletooltips generally do not appear on disabled<button>elements in browsers. Since this action is disabled when!projectId, mouse users wonβt see the tooltip in that state. Consider putting thetitleon a wrapper element and making the disabled button ignore pointer events so the wrapper can show the tooltip.
onClick={projectId ? () => void handleRemove(projectId, attachment) : undefined}
disabled={!projectId}
aria-label={`${t("scoreRemove")}: ${attachment.fileName}`}
title={`${t("scoreRemove")}: ${attachment.fileName}`}
className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10"
services/analysis-engine/pyproject.toml:15
- The PR description is scoped to adding tooltips (
title) for desktop score-viewer icon buttons, but this change set also adds a new Python runtime dependency (setuptools) and updates lockfiles (e.g., torch/cuda-toolkit inuv.lock,brace-expansioninpackage-lock.json). These dependency updates are unrelated to the stated UI goal and increase review/rollout risk; consider splitting them into a separate dependency-update PR (or reverting them here).
"demucs>=4.0.1 ; sys_platform != 'darwin' or platform_machine == 'arm64'",
"librosa>=0.11.0",
"numba<0.67.0",
"numpy>=1.26",
"setuptools>=71.1.0",
|
Closing as closed-obsolete (palette a11y micro-PR storm) by autonomous product-completion loop. Winner / disposition target: #727 Unique value from this cluster is consolidated there (projectId path guard + npm HIGH CVE pins + Foote novelty kernel sign). Remaining micro-duplicates do not land additional commercial readiness. |
|
closed-closed-obsolete (palette a11y micro-PR storm) β #727 |
μ΄ν΄νμ΅λλ€. μ΄ μμ μ΄ λ μ΄μ νμνμ§ μμμ νμΈνμΌλ©° μ΄ μμ μ λν μ§νμ μ€λ¨νκ² μ΅λλ€. |
νμΈνμ΅λλ€. |
π‘ 무μμ: μ 보 λ·°μ΄(ScoreViewer)μ μ 보 κ΄λ¦¬(ScoreView) νλ©΄μ μμ΄μ½ μ μ© λ²νΌλ€μ
titleμμ±μ μΆκ°νμ΅λλ€.π― μ: κΈ°μ‘΄μλ μκ° μ₯μ μΈμ μν
aria-labelλ§ μ 곡λμ΄ λ§μ°μ€λ₯Ό μ¬μ©νλ μΌλ° μκ° μ¬μ©μλ€μκ²λ λ²νΌμ κΈ°λ₯μ΄ ν΄νμΌλ‘ νμλμ§ μλ λΆνΈν¨μ΄ μμμ΅λλ€.πΈ Before/After: μκ°μ μΈ λ μ΄μμ λ³κ²½μ μμΌλ©°, λ²νΌ νΈλ² μ λ§μ°μ€ 컀μ μμ ν΄νμ΄ λνλ©λλ€.
βΏ Accessibility: λ§μ°μ€ μ¬μ©μλ€μ νμ κ²½ν λ° μ¬μ©μ±μ΄ κ°μ λμμ΅λλ€.
PR created automatically by Jules for task 12360190235958251187 started by @seonghobae