Skip to content

🎨 Palette: 악보 λ·°μ–΄ μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ - #691

Closed
seonghobae wants to merge 4 commits into
developfrom
jules-12360190235958251187-7bf4c70b
Closed

🎨 Palette: 악보 λ·°μ–΄ μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€#691
seonghobae wants to merge 4 commits into
developfrom
jules-12360190235958251187-7bf4c70b

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ 무엇을: 악보 λ·°μ–΄(ScoreViewer)와 악보 관리(ScoreView) ν™”λ©΄μ˜ μ•„μ΄μ½˜ μ „μš© λ²„νŠΌλ“€μ— title 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 μ™œ: κΈ°μ‘΄μ—λŠ” μ‹œκ° μž₯애인을 μœ„ν•œ aria-label만 μ œκ³΅λ˜μ–΄ 마우슀λ₯Ό μ‚¬μš©ν•˜λŠ” 일반 μ‹œκ° μ‚¬μš©μžλ“€μ—κ²ŒλŠ” λ²„νŠΌμ˜ κΈ°λŠ₯이 툴팁으둜 ν‘œμ‹œλ˜μ§€ μ•ŠλŠ” λΆˆνŽΈν•¨μ΄ μžˆμ—ˆμŠ΅λ‹ˆλ‹€.
πŸ“Έ Before/After: μ‹œκ°μ μΈ λ ˆμ΄μ•„μ›ƒ 변경은 μ—†μœΌλ©°, λ²„νŠΌ ν˜Έλ²„ μ‹œ 마우슀 μ»€μ„œ μ˜†μ— 툴팁이 λ‚˜νƒ€λ‚©λ‹ˆλ‹€.
β™Ώ Accessibility: 마우슀 μ‚¬μš©μžλ“€μ˜ 탐색 κ²½ν—˜ 및 μ‚¬μš©μ„±μ΄ κ°œμ„ λ˜μ—ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 12360190235958251187 started by @seonghobae

마우슀 μ‚¬μš©μžλ“€μ˜ μ‚¬μš©μ„±μ„ κ°œμ„ ν•˜κΈ° μœ„ν•΄ ν…μŠ€νŠΈ 없이 μ•„μ΄μ½˜λ§Œ μžˆλŠ” λ²„νŠΌμ— `title` 속성을 μΆ”κ°€ν•˜μ—¬ λ„€μ΄ν‹°λΈŒ λΈŒλΌμš°μ € 툴팁이 ν‘œμ‹œλ˜λ„λ‘ ν–ˆμŠ΅λ‹ˆλ‹€. (ScoreView 및 ScoreViewer μ»΄ν¬λ„ŒνŠΈ)
Copilot AI review requested due to automatic review settings July 23, 2026 03:58
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds native browser tooltips (title) to icon(-heavy) controls in the desktop score UI so mouse users can discover actions via hover text while keeping existing aria-label accessibility intact.

Changes:

  • Added title attributes to ScoreViewer navigation/zoom/fit controls using existing i18n keys.
  • Added a title attribute to the score attachment β€œremove” icon button, including the filename for clarity.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
apps/desktop/src/features/score/ScoreViewer.tsx Adds title tooltips to zoom/fit/page navigation buttons via existing translations.
apps/desktop/src/features/score/ScoreView.tsx Adds a title tooltip to the attachment remove icon button (includes filename).
Comments suppressed due to low confidence (1)

apps/desktop/src/features/score/ScoreViewer.tsx:314

  • Same issue for the next-page icon: when disabled at the end of the document, the title tooltip usually won’t show. A wrapper element with the same title preserves the tooltip even when the button is disabled.
            className="size-14"
            aria-label={t("scoreViewerNextPage")}
            title={t("scoreViewerNextPage")}
            disabled={pageNumber >= pageCount}
            onClick={goToNextPage}

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 296 to 300
className="size-14"
aria-label={t("scoreViewerPrevPage")}
title={t("scoreViewerPrevPage")}
disabled={pageNumber <= 1}
onClick={goToPreviousPage}
Comment on lines 199 to 203
disabled={!projectId}
aria-label={`${t("scoreRemove")}: ${attachment.fileName}`}
title={`${t("scoreRemove")}: ${attachment.fileName}`}
className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10"
>
마우슀 μ‚¬μš©μžλ“€μ˜ μ‚¬μš©μ„±μ„ κ°œμ„ ν•˜κΈ° μœ„ν•΄ ν…μŠ€νŠΈ 없이 μ•„μ΄μ½˜λ§Œ μžˆλŠ” λ²„νŠΌμ— `title` 속성을 μΆ”κ°€ν•˜μ—¬ λ„€μ΄ν‹°λΈŒ λΈŒλΌμš°μ € 툴팁이 ν‘œμ‹œλ˜λ„λ‘ ν–ˆμŠ΅λ‹ˆλ‹€. (ScoreView 및 ScoreViewer μ»΄ν¬λ„ŒνŠΈ)
Copilot AI review requested due to automatic review settings July 23, 2026 04:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

마우슀 μ‚¬μš©μžλ“€μ˜ μ‚¬μš©μ„±μ„ κ°œμ„ ν•˜κΈ° μœ„ν•΄ ν…μŠ€νŠΈ 없이 μ•„μ΄μ½˜λ§Œ μžˆλŠ” λ²„νŠΌμ— `title` 속성을 μΆ”κ°€ν•˜μ—¬ λ„€μ΄ν‹°λΈŒ λΈŒλΌμš°μ € 툴팁이 ν‘œμ‹œλ˜λ„λ‘ ν–ˆμŠ΅λ‹ˆλ‹€. (ScoreView 및 ScoreViewer μ»΄ν¬λ„ŒνŠΈ)
μΆ”κ°€λ‘œ Trivy λ³΄μ•ˆ 감사λ₯Ό ν†΅κ³Όν•˜κΈ° μœ„ν•΄ analysis-engine의 setuptools 버전을 71.1.0 μ΄μƒμœΌλ‘œ μ—…λ°μ΄νŠΈν•˜κ³ , ν”„λ‘ νŠΈμ—”λ“œμ˜ brace-expansion 취약점을 npm audit fix둜 ν•΄κ²°ν–ˆμŠ΅λ‹ˆλ‹€.
Copilot AI review requested due to automatic review settings July 23, 2026 04:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.

Comment on lines 14 to 16
"numpy>=1.26",
"setuptools>=71.1.0",
"soundfile>=0.13.1",
마우슀 μ‚¬μš©μžλ“€μ˜ μ‚¬μš©μ„±μ„ κ°œμ„ ν•˜κΈ° μœ„ν•΄ ν…μŠ€νŠΈ 없이 μ•„μ΄μ½˜λ§Œ μžˆλŠ” λ²„νŠΌμ— `title` 속성을 μΆ”κ°€ν•˜μ—¬ λ„€μ΄ν‹°λΈŒ λΈŒλΌμš°μ € 툴팁이 ν‘œμ‹œλ˜λ„λ‘ ν–ˆμŠ΅λ‹ˆλ‹€. (ScoreView 및 ScoreViewer μ»΄ν¬λ„ŒνŠΈ)
μΆ”κ°€λ‘œ Trivy λ³΄μ•ˆ 감사λ₯Ό ν†΅κ³Όν•˜κΈ° μœ„ν•΄ analysis-engine의 setuptools 버전을 71.1.0 μ΄μƒμœΌλ‘œ μ—…λ°μ΄νŠΈν•˜κ³ , ν”„λ‘ νŠΈμ—”λ“œμ˜ brace-expansion 취약점을 npm audit fix둜 ν•΄κ²°ν–ˆμŠ΅λ‹ˆλ‹€.
Copilot AI review requested due to automatic review settings July 23, 2026 04:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (4)

apps/desktop/src/features/score/ScoreViewer.tsx:301

  • title tooltips generally do not appear on disabled <button> elements in browsers. Since this control is sometimes disabled (pageNumber <= 1), mouse users won’t see the tooltip in that state. Consider wrapping the button in an element with the title and making the disabled button ignore pointer events so the wrapper can show the tooltip.
            aria-label={t("scoreViewerPrevPage")}
            title={t("scoreViewerPrevPage")}
            disabled={pageNumber <= 1}
            onClick={goToPreviousPage}
          >

apps/desktop/src/features/score/ScoreViewer.tsx:315

  • title tooltips generally do not appear on disabled <button> elements in browsers. Since this control is sometimes disabled (pageNumber >= pageCount), mouse users won’t see the tooltip in that state. Consider wrapping the button in an element with the title and making the disabled button ignore pointer events so the wrapper can show the tooltip.
            aria-label={t("scoreViewerNextPage")}
            title={t("scoreViewerNextPage")}
            disabled={pageNumber >= pageCount}
            onClick={goToNextPage}
          >

apps/desktop/src/features/score/ScoreView.tsx:202

  • title tooltips generally do not appear on disabled <button> elements in browsers. Since this action is disabled when !projectId, mouse users won’t see the tooltip in that state. Consider putting the title on a wrapper element and making the disabled button ignore pointer events so the wrapper can show the tooltip.
                      onClick={projectId ? () => void handleRemove(projectId, attachment) : undefined}
                      disabled={!projectId}
                      aria-label={`${t("scoreRemove")}: ${attachment.fileName}`}
                      title={`${t("scoreRemove")}: ${attachment.fileName}`}
                      className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10"

services/analysis-engine/pyproject.toml:15

  • The PR description is scoped to adding tooltips (title) for desktop score-viewer icon buttons, but this change set also adds a new Python runtime dependency (setuptools) and updates lockfiles (e.g., torch/cuda-toolkit in uv.lock, brace-expansion in package-lock.json). These dependency updates are unrelated to the stated UI goal and increase review/rollout risk; consider splitting them into a separate dependency-update PR (or reverting them here).
    "demucs>=4.0.1 ; sys_platform != 'darwin' or platform_machine == 'arm64'",
    "librosa>=0.11.0",
    "numba<0.67.0",
    "numpy>=1.26",
    "setuptools>=71.1.0",

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Closing as closed-obsolete (palette a11y micro-PR storm) by autonomous product-completion loop.

Winner / disposition target: #727

Unique value from this cluster is consolidated there (projectId path guard + npm HIGH CVE pins + Foote novelty kernel sign). Remaining micro-duplicates do not land additional commercial readiness.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

closed-closed-obsolete (palette a11y micro-PR storm) β†’ #727

@seonghobae seonghobae closed this Jul 31, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as closed-obsolete (palette a11y micro-PR storm) by autonomous product-completion loop.

Winner / disposition target: #727

Unique value from this cluster is consolidated there (projectId path guard + npm HIGH CVE pins + Foote novelty kernel sign). Remaining micro-duplicates do not land additional commercial readiness.

μ΄ν•΄ν–ˆμŠ΅λ‹ˆλ‹€. 이 μž‘μ—…μ΄ 더 이상 ν•„μš”ν•˜μ§€ μ•ŠμŒμ„ ν™•μΈν–ˆμœΌλ©° 이 μž‘μ—…μ— λŒ€ν•œ 진행을 μ€‘λ‹¨ν•˜κ² μŠ΅λ‹ˆλ‹€.

@google-labs-jules

Copy link
Copy Markdown

closed-closed-obsolete (palette a11y micro-PR storm) β†’ #727

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants