Skip to content

🎨 Palette: 악보 λ·°μ–΄ μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 4 commits into from
Closed

🎨 Palette: 악보 λ·°μ–΄ μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
470b9d8
feat(ux): μ•„μ΄μ½˜ λ²„νŠΌμ— 툴팁 μΆ”κ°€
seonghobae Jul 23, 2026
31942cc
feat(ux): μ•„μ΄μ½˜ λ²„νŠΌμ— 툴팁 μΆ”κ°€
seonghobae Jul 23, 2026
8f6dc60
feat(ux): μ•„μ΄μ½˜ λ²„νŠΌμ— 툴팁 μΆ”κ°€ 및 λ³΄μ•ˆ 취약점 ν•΄κ²°
seonghobae Jul 23, 2026
a41eca4
feat(ux): μ•„μ΄μ½˜ λ²„νŠΌμ— 툴팁 μΆ”κ°€ 및 λ³΄μ•ˆ 취약점 ν•΄κ²°
seonghobae Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/desktop/src/features/score/ScoreView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ export function ScoreView({ song, projectId, onSongUpdate }: ScoreViewProps) {
onClick={projectId ? () => void handleRemove(projectId, attachment) : undefined}
disabled={!projectId}
aria-label={`${t("scoreRemove")}: ${attachment.fileName}`}
title={`${t("scoreRemove")}: ${attachment.fileName}`}
className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10"
>
Comment on lines 199 to 203
<Trash2 className="size-4" aria-hidden="true" />
Expand Down
5 changes: 5 additions & 0 deletions apps/desktop/src/features/score/ScoreViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
size="icon-lg"
className="size-12"
aria-label={t("scoreViewerZoomOut")}
title={t("scoreViewerZoomOut")}
onClick={zoomOut}
>
<ZoomOut aria-hidden="true" />
Expand All @@ -267,6 +268,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
size="icon-lg"
className="size-12"
aria-label={t("scoreViewerZoomIn")}
title={t("scoreViewerZoomIn")}
onClick={zoomIn}
>
<ZoomIn aria-hidden="true" />
Expand All @@ -275,6 +277,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
variant={fitWidth ? "secondary" : "outline"}
className="h-12 px-4 text-base"
aria-label={t("scoreViewerFitWidth")}
title={t("scoreViewerFitWidth")}
aria-pressed={fitWidth}
onClick={fitToWidth}
>
Expand All @@ -292,6 +295,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
size="icon-lg"
className="size-14"
aria-label={t("scoreViewerPrevPage")}
title={t("scoreViewerPrevPage")}
disabled={pageNumber <= 1}
onClick={goToPreviousPage}
Comment on lines 296 to 300
>
Expand All @@ -305,6 +309,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
size="icon-lg"
className="size-14"
aria-label={t("scoreViewerNextPage")}
title={t("scoreViewerNextPage")}
disabled={pageNumber >= pageCount}
onClick={goToNextPage}
>
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion services/analysis-engine/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ dependencies = [
"librosa>=0.11.0",
"numba<0.67.0",
"numpy>=1.26",
"setuptools>=71.1.0",
"soundfile>=0.13.1",
Comment on lines 14 to 16
"urllib3>=2.7.0",
"urllib3>=2.7.0",
"yt-dlp>=2026.6.9",
]

Expand Down
Loading
Loading