fix(security): establish canonical npm, PDF.js, and Undici baseline - #783
fix(security): establish canonical npm, PDF.js, and Undici baseline#783seonghobae wants to merge 37 commits into
Conversation
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
Comment |
|
@opencode-agent address Finalize the generated security lock on exact current head CI run Before committing, fail closed unless the generated lock proves all of the following:
Replace the branch lock byte-for-byte with the verified artifact and commit normally. Do not regenerate it locally, hand-edit it, create another branch/PR/workflow/helper, or include the ZIP. The next exact-head CI must reproduce a zero diff before any build/security success is accepted. |
|
/oc Refetch the live pull request and abort without writing unless it is still PR #783 on branch |
|
@coderabbitai review |
|
Problem
Protected
developcarries two high-severity JavaScript dependency findings and does not make the lockfile generator an enforceable repository contract:pdfjs-dist@6.1.200, affected by arbitrary JavaScript execution on malicious PDFs and fixed in6.2.108;undici@7.28.0, affected by cache-control disclosure/crash, header injection, retry desynchronization, and cookie-attribute injection findings fixed in7.29.0; andpeer: truefrom@esbuild/*locations.Atomic baseline
This PR now targets protected
developdirectly and combines the npm-generator provenance slice from #782 with the coordinated PDF.js/Undici remediation. It is the intended atomic supply-chain baseline rather than a child stacked on #782.The implementation:
npm@10.9.8as the package-lock generator;22.22.3and npm10.9.8before install;package-lock.jsonwith scripts, audit, and funding disabled and rejects any replay diff;pdfjs-distexactly to6.2.108;7.29.0through the root override;@esbuild/*peer metadata;DocumentInitParametersrather than passing the removed legacyisEvalSupportedoption;Verified lock evidence
The exact npm 10.9.8 reproduction artifact from workflow run
31161313485was imported unchanged:8989562185;31dd2661eca864e3da46f86629a2535dc181d01449bd3a50fa3cdbd6c58e7971;npm audit --workspaces --audit-level=high: zero vulnerabilities;Exact-head gate
Current exact head:
e6b48ca58e5c481e4b0bef8961338b5a3967e6c6.Current protected base:
acdbea6344fe1231c39535b575f4de35e4c607c9.Keep Draft until the exact-current-head desktop, Rust/Tauri, package, release, security, SAST, SBOM, central coverage, CodeRabbit, OpenCode, and Noema gates complete; every actionable thread is resolved; a qualifying independent non-author approval is anchored to this exact head; and branch protection permits merge without administrative bypass. Queued, skipped-required, action-required, author-only, prior-head, or wrapper-only evidence is not success.
After this PR merges, close #782, #751, and #765 as superseded. No predecessor review or check is reused.