fix(security): keep every CodeQL Action phase on one revision - #780
fix(security): keep every CodeQL Action phase on one revision#780seonghobae wants to merge 15 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/oc Refetch the live pull request and abort without writing unless its exact head is |
Problem
Dependabot opened separate updates for CodeQL
init,autobuild,analyze, andupload-sarif. Merging those pull requests independently would create an unreviewed mixed CodeQL lifecycle and could leave SARIF publishers on a different implementation revision. The split PR comments also mislabeled a newer SHA as v4.37.0.Test-first evidence
RED head
4c6bd0828afb1cf6869d8658f43f5b7f334cbbf7added onlyservices/analysis-engine/tests/test_codeql_action_revision_contract.py. Against protecteddevelop, both focused contracts failed because all CodeQL phases still resolved to v4.37.0 rather than the expected reviewed v4.37.6 SHA.Current exact head:
8aced19e82b1aefad54b370e2986de700ef4d75b.The implementation now:
init,autobuild,analyze, andupload-sarifreference to CodeQL Action v4.37.6 commit5595ccaf912efad79be6eef63a5619ff05969be3;docs/doctoring/codeql-action-atomic-revision.md; andCHANGELOG.mdunder Unreleased.The focused contract is GREEN in an independently reconstructed exact-file test run (
2 passed). GitHub-hosted exact-head CI, security, supply-chain, central review, and branch-protection evidence remain authoritative and must complete before Ready or merge.Supersession
After this coordinated PR is exact-head green and review-complete, it supersedes split Dependabot PRs #764, #766, #767, and #768. Their predecessor-head checks and reviews are not transferable.
Merge gate
Keep Draft until full repository CI/security/supply-chain checks succeed on this exact head, CodeRabbit/OpenCode/Noema and a qualifying independent non-author approval are current, all actionable threads are resolved, and branch protection permits merge without bypass.