Skip to content

chore: fix cargo audit warnings and python test coverage warnings - #99

Merged
seonghobae merged 1 commit into
developfrom
fix/security-warnings-coverage
Mar 27, 2026
Merged

chore: fix cargo audit warnings and python test coverage warnings#99
seonghobae merged 1 commit into
developfrom
fix/security-warnings-coverage

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Resolves cargo audit warnings inherited from Tauri v2 webkit2gtk by adding ignores in .cargo/audit.toml as documented in docs/security/dependency-policy.md. Also fixes a python RuntimeWarning during tests to maintain 100% coverage cleanly.

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4eebd0cb-d8f2-480d-9c44-733d987d2e4e

📥 Commits

Reviewing files that changed from the base of the PR and between a90f5c7 and 67ab322.

📒 Files selected for processing (3)
  • apps/desktop/src-tauri/.cargo/audit.toml
  • docs/security/dependency-policy.md
  • services/analysis-engine/tests/test_cli.py

Cache: Disabled due to Reviews > Disable Cache setting

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Summary by CodeRabbit

릴리스 노트

  • Documentation

    • 보안 의존성 정책 문서에 상속된 레거시 취약점에 대한 통제된 예외 항목을 추가했습니다.
  • Chores

    • 감사 도구 설정을 추가해 일부 보안 권고를 제외하도록 구성했습니다.
  • Tests

    • 테스트 실행 중 발생하는 런타임 경고를 일시적으로 무시하도록 테스트 경고 처리 로직을 개선했습니다.

Walkthrough

Cargo 감사 구성 파일을 추가해 특정 RustSec 권고사항을 무시하도록 설정하고, 보안 정책 문서에 해당 예외를 기록하며, 테스트에서 런타임 경고를 억제하는 필터를 도입합니다.

Changes

Cohort / File(s) Summary
Cargo 감사 구성
apps/desktop/src-tauri/.cargo/audit.toml
[advisories]ignore 배열에 여러 RustSec 권고 ID를 추가하여 Cargo audit 보고서에서 제외합니다.
보안 정책 문서화
docs/security/dependency-policy.md
“Current controlled exception”에 Tauri v2의 wry/webkit2gtk를 통해 상속된 gtk3, glib, fxhash 관련 취약점 예외를 추가했습니다.
테스트 수정
services/analysis-engine/tests/test_cli.py
runpy.run_module(...) 실행을 warnings.catch_warnings()warnings.simplefilter("ignore", RuntimeWarning)로 감싸 런타임 경고를 억제하도록 변경했습니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 감사 파일에 숨긴 예외들, 조용히 적어두었네,
문서엔 이유를 담아 기록했지,
테스트 속 경고는 살며시 잠들고,
작은 작업 하나로 평온한 빌드가 오네. 🥕

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/security-warnings-coverage

Comment @coderabbitai help to get the list of available commands and usage tips.

@seonghobae
seonghobae enabled auto-merge (squash) March 27, 2026 04:03
@seonghobae
seonghobae merged commit 1e3f6f6 into develop Mar 27, 2026
22 of 23 checks passed
@seonghobae

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant