Skip to content

chore: fix cargo audit warnings and python test coverage warnings #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 1 commit into from
Mar 27, 2026
Merged

chore: fix cargo audit warnings and python test coverage warnings #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions apps/desktop/src-tauri/.cargo/audit.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
[advisories]
ignore = [
"RUSTSEC-2024-0413", # atk: gtk-rs GTK3 bindings - no longer maintained
"RUSTSEC-2024-0416", # atk-sys
"RUSTSEC-2025-0057", # fxhash: no longer maintained
"RUSTSEC-2024-0412", # gdk
"RUSTSEC-2024-0418", # gdk-sys
"RUSTSEC-2024-0411", # gdkwayland-sys
"RUSTSEC-2024-0417", # gdkx11
"RUSTSEC-2024-0414", # gdkx11-sys
"RUSTSEC-2024-0415", # gtk
"RUSTSEC-2024-0420", # gtk-sys
"RUSTSEC-2024-0419", # gtk3-macros
"RUSTSEC-2024-0370", # proc-macro-error: unmaintained
"RUSTSEC-2025-0081", # unic-char-property: unmaintained
"RUSTSEC-2025-0075", # unic-char-range: unmaintained
"RUSTSEC-2025-0080", # unic-common: unmaintained
"RUSTSEC-2025-0100", # unic-ucd-ident: unmaintained
"RUSTSEC-2025-0098", # unic-ucd-version: unmaintained
"RUSTSEC-2024-0429" # glib: unsoundness in VariantStrIter
]
1 change: 1 addition & 0 deletions docs/security/dependency-policy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ Exceptions are allowed only when no patched version exists and the advisory is n
Current controlled exception:

- `GHSA-5239-wwwm-4pmq` (`Pygments <=2.19.2`) in Python dev/test dependency path; no patched version is available at this time, impact is low/local-access ReDoS, and BandScope does not expose Pygments parsing on untrusted runtime input paths. The CI `security-audit` workflow applies a targeted ignore for this advisory only.
- Cargo audit warnings for legacy `gtk3`, `glib`, and `fxhash` vulnerabilities (e.g. `RUSTSEC-2024-0413`, `RUSTSEC-2024-0429`, `RUSTSEC-2025-0057`) inherited through Tauri v2 `wry`/`webkit2gtk` integration are explicitly allowed. These are deep framework dependencies with no alternative, so they are documented exceptions and ignored by default.

## Required checks intent

Expand Down
5 changes: 4 additions & 1 deletion services/analysis-engine/tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import runpy
import subprocess
import sys
import warnings
from pathlib import Path

from bandscope_analysis import cli
Expand Down Expand Up @@ -212,7 +213,9 @@ def test_cli_module_runs_as_main(monkeypatch) -> None:
monkeypatch.setattr(sys, "stdout", stdout)

try:
runpy.run_module("bandscope_analysis.cli", run_name="__main__")
with warnings.catch_warnings():
warnings.simplefilter("ignore", RuntimeWarning)
runpy.run_module("bandscope_analysis.cli", run_name="__main__")
except SystemExit as exit_signal:
assert exit_signal.code == 0

Expand Down
Loading