🎨 Palette: [접근성 개선] 시맨틱 네비게이션 태그 및 포커스 시각 효과 추가 by seonghobae · Pull Request #23 · ContextualWisdomLab/html4tree

seonghobae · 2026-06-25T03:26:10Z

💡 What: HTML 트리 생성 시 결과물인 index.html에 언어 속성을 추가하고, 디렉토리 리스트를 감싸는 <nav> 요소와 함께 키보드 네비게이션 포커스/호버 효과 CSS를 추가했습니다.
🎯 Why: 스크린 리더 사용자가 디렉토리 목록을 탐색할 때 이를 네비게이션 영역으로 명확히 인식하게 하고, 키보드로 탐색하는 사용자들이 현재 포커스 된 항목을 명확하게 파악할 수 있도록 돕기 위함입니다.
📸 Before/After: 해당 없음 (순수 HTML/CSS 구조 변경 및 터미널 출력 결과물).
♿ Accessibility: <html lang="en"> 속성을 통해 언어를 지정하고 <nav aria-label="Directory listing">를 사용해 파일 리스트를 네비게이션으로 정의했습니다. 또한, 링크의 :focus-visible 및 :hover 스타일을 적용해 시각 장애 또는 키보드 전용 사용자들의 사용성을 개선했습니다.
✅ 추가로 Jacoco를 도입하고 100% 테스트 커버리지를 만족하도록 기존 코드 및 테스트 코드를 업데이트했습니다.

PR created automatically by Jules for task 17555599533290961065 started by @seonghobae

- 생성되는 index.html에 `<html lang="en">` 추가 - 디렉토리 목록을 `<nav aria-label="Directory listing">`으로 감싸 스크린 리더 등 접근성 개선 - 키보드 네비게이션을 위한 focus 및 hover 상태 시각적 피드백 CSS 추가 - Jacoco를 통한 100% 테스트 커버리지 달성 - `.Jules/palette.md` 파일에 접근성 관련 학습 내용 기록

google-labs-jules · 2026-06-25T03:26:12Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

Copilot

Pull request overview

This PR improves the accessibility of generated index.html directory listings by adding semantic navigation markup and clearer keyboard focus/hover styling, and introduces JaCoCo-based coverage enforcement with new/updated tests to meet the stated coverage target.

Changes:

Add <html lang="en">, wrap the directory list in <nav aria-label="Directory listing">, and add :hover / :focus-visible link styles in the generated HTML.
Add JaCoCo configuration and enforce 100% test coverage during check.
Add Kotlin/JUnit tests covering core utilities and directory processing.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/test/kotlin/html4tree/MainTest.kt	Adds integration-style tests for main flow, HTML generation, and utility functions.
src/test/kotlin/html4tree/LinkedListTest.kt	Adds focused unit tests for the custom `LinkedList`.
src/main/kotlin/html4tree/util.kt	Tightens `LinkedList` encapsulation and simplifies push logic.
src/main/kotlin/html4tree/main.kt	Adds semantic `<nav>` wrapper, `lang` attribute, and focus/hover CSS to generated HTML.
build.gradle	Enables JaCoCo, configures reports + 100% coverage verification, and updates JUnit version.
.Jules/palette.md	Documents the accessibility rationale/learning for the change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

… in testHelp

…-17555599533290961065 # Conflicts: # src/main/kotlin/html4tree/main.kt # src/test/kotlin/html4tree/MainTest.kt

opencode-agent

Pull request overview

OpenCode model attempts did not emit a usable current-head control block, so the approval gate used deterministic current-head evidence instead of model prose.

Findings

No blocking findings.

Summary

Result: APPROVE
Reason: coverage-evidence passed, peer GitHub Checks completed without failures, mergeability was clean, and no unresolved human review threads remained.
Deterministic evidence: current-head changed-file evidence (.jules/palette.md, src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/MainTest.kt); coverage-evidence result success; peer checks from statusCheckRollup excluding this OpenCode check.
Model outcomes: primary=failed, fallback=failed, second_fallback=failed, catalog_fallback=failed.
Head SHA: d8343aff3d4402b5dc49ef440bdf497b99659cbc
Workflow run: 28417975813
Workflow attempt: 1

Deterministic fallback approval was used only after model-output instability and did not bypass coverage, failed-check, mergeability, or human-review gates.

Change Flow DAG

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]

opencode-agent · 2026-06-30T03:33:52Z

OpenCode Review Overview

Head SHA: d8343aff3d4402b5dc49ef440bdf497b99659cbc
Workflow run: 28417975813
Workflow attempt: 1
Gate result: APPROVE (approval step)

Pull request overview

OpenCode model attempts did not emit a usable current-head control block, so the approval gate used deterministic current-head evidence instead of model prose.

Findings

No blocking findings.

Summary

Result: APPROVE
Reason: coverage-evidence passed, peer GitHub Checks completed without failures, mergeability was clean, and no unresolved human review threads remained.
Deterministic evidence: current-head changed-file evidence (.jules/palette.md, src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/MainTest.kt); coverage-evidence result success; peer checks from statusCheckRollup excluding this OpenCode check.
Model outcomes: primary=failed, fallback=failed, second_fallback=failed, catalog_fallback=failed.
Head SHA: d8343aff3d4402b5dc49ef440bdf497b99659cbc
Workflow run: 28417975813
Workflow attempt: 1

Deterministic fallback approval was used only after model-output instability and did not bypass coverage, failed-check, mergeability, or human-review gates.

Change Flow DAG

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]

This PR is now considered obsolete based on feedback that the security enhancements (CSP/charset hardening) have already been merged via #23/#45. Closing and abandoning changes on this branch.

Copilot AI review requested due to automatic review settings June 25, 2026 03:26

Copilot started reviewing on behalf of seonghobae June 25, 2026 03:36 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread src/test/kotlin/html4tree/MainTest.kt Outdated

Copilot started work on behalf of seonghobae June 28, 2026 08:50 View session

fix: wrap System.out redirection in try/finally with explicit charset…

1caadb0

… in testHelp

Copilot finished work on behalf of seonghobae June 28, 2026 08:52

seonghobae and others added 2 commits June 29, 2026 02:57

Resolve master conflicts for PR 23

dea0d6f

Merge remote-tracking branch 'origin/master' into palette-ux-nav-a11y…

d8343af

…-17555599533290961065 # Conflicts: # src/main/kotlin/html4tree/main.kt # src/test/kotlin/html4tree/MainTest.kt

opencode-agent Bot approved these changes Jun 30, 2026

View reviewed changes

seonghobae merged commit 0a15628 into master Jun 30, 2026
5 checks passed

seonghobae added a commit that referenced this pull request Jun 30, 2026

[Close] OBSELETE PR

df466c3

This PR is now considered obsolete based on feedback that the security enhancements (CSP/charset hardening) have already been merged via #23/#45. Closing and abandoning changes on this branch.

Navigation Menu

Uh oh!

🎨 Palette: [접근성 개선] 시맨틱 네비게이션 태그 및 포커스 시각 효과 추가 - #23

🎨 Palette: [접근성 개선] 시맨틱 네비게이션 태그 및 포커스 시각 효과 추가#23
seonghobae merged 4 commits into
masterfrom
palette-ux-nav-a11y-17555599533290961065

seonghobae commented Jun 25, 2026

Uh oh!

google-labs-jules Bot commented Jun 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

opencode-agent Bot left a comment

Uh oh!

opencode-agent Bot commented Jun 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

seonghobae commented Jun 25, 2026

Uh oh!

google-labs-jules Bot commented Jun 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

opencode-agent Bot left a comment

Choose a reason for hiding this comment

Pull request overview

Findings

Summary

Change Flow DAG

Uh oh!

opencode-agent Bot commented Jun 30, 2026

OpenCode Review Overview

Pull request overview

Findings

Summary

Change Flow DAG

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants