Skip to content

Integrate GolangCI v2 via Crust#219

Merged
TxCorpi0x merged 6 commits intomasterfrom
mehdi/golangci-v2-fix
Jun 9, 2025
Merged

Integrate GolangCI v2 via Crust#219
TxCorpi0x merged 6 commits intomasterfrom
mehdi/golangci-v2-fix

Conversation

@TxCorpi0x
Copy link
Contributor

@TxCorpi0x TxCorpi0x commented May 27, 2025 •
edited
Loading

Description

Upgrade the crust release-v5 to the latest version, dependent to Crust PR#483 and Coreum-Tools PR#33

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@TxCorpi0x TxCorpi0x requested a review from a team as a code owner May 27, 2025 06:06
@TxCorpi0x TxCorpi0x requested review from masihyeganeh, miladz68 and ysv and removed request for a team May 27, 2025 06:06
@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from b025bbb to 242081b Compare May 27, 2025 06:13
miladz68
miladz68 previously approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @masihyeganeh and @ysv)

masihyeganeh
masihyeganeh previously approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ysv)

@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from 242081b to c2811f1 Compare May 27, 2025 13:09
@TxCorpi0x TxCorpi0x dismissed stale reviews from masihyeganeh and miladz68 via cbe39da May 27, 2025 13:44
@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from c2811f1 to cbe39da Compare May 27, 2025 13:44
@TxCorpi0x TxCorpi0x closed this May 27, 2025
@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from 943632c to 5229bda Compare May 27, 2025 14:29
@TxCorpi0x TxCorpi0x reopened this May 27, 2025
ysv
ysv previously approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 20 files at r1, 21 of 21 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from e2141e8 to cbcab8d Compare May 28, 2025 06:20
miladz68
miladz68 reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 21 files at r2, 1 of 3 files at r3, 6 of 6 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

miladz68
miladz68 previously approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 36 of 38 files reviewed, all discussions resolved (waiting on @TxCorpi0x)

masihyeganeh
masihyeganeh previously approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 21 files at r2, 2 of 7 files at r5, 5 of 5 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from 18d1180 to 402bd5b Compare May 28, 2025 09:12
miladz68
miladz68 previously approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r5, 5 of 5 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

masihyeganeh
masihyeganeh previously approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

@TxCorpi0x TxCorpi0x dismissed stale reviews from masihyeganeh and miladz68 via 8ff8609 May 29, 2025 11:37
@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from b540ffb to 8ff8609 Compare May 29, 2025 11:37
masihyeganeh
masihyeganeh previously approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

@TxCorpi0x TxCorpi0x closed this May 30, 2025
@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from 06d1136 to 5229bda Compare May 30, 2025 16:06
@TxCorpi0x TxCorpi0x reopened this May 30, 2025
@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch 2 times, most recently from d971a7c to da485d4 Compare June 2, 2025 17:42
@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from da485d4 to 307d603 Compare June 2, 2025 17:46
masihyeganeh
masihyeganeh previously approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 8 files at r11, 38 of 38 files at r12, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch 5 times, most recently from f88487d to 522207c Compare June 6, 2025 11:36
TxCorpi0x added 3 commits June 9, 2025 08:33
@TxCorpi0x
Rename OperationID to OperationSequence (#218)
6e515ca 
* Add save_evidence operation_unique_id

* Use serde for save_signature

* Rename operation ID to operation sequence in relevant files and update related logic

Renames operation ID to operation sequence in cancelPendingOp

Updates the `CancelPendingOperation` message to use `operation_sequence` instead of `operation_id`.

This change provides more clarity and consistency in how pending operations are identified and cancelled.

* Merge branch 'master' into mehdi/unique-operation-id-save-evidence-replace
@TxCorpi0x
Upgrade crust and znet to the latest crust
bb2470b
@TxCorpi0x
Rplace context with t.context
ad47ef7
@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch 2 times, most recently from b3377c3 to c60c41e Compare June 9, 2025 05:43
@TxCorpi0x TxCorpi0x force-pushed the mehdi/golangci-v2-fix branch from c60c41e to 7c64f74 Compare June 9, 2025 06:18
masihyeganeh
masihyeganeh approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@masihyeganeh masihyeganeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 27 files at r14, 18 of 18 files at r15, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

@TxCorpi0x TxCorpi0x mentioned this pull request Jun 9, 2025
Closed
6 tasks
miladz68
miladz68 approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 33 of 38 files at r12, 9 of 27 files at r14, 18 of 18 files at r15, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TxCorpi0x)

@TxCorpi0x TxCorpi0x merged commit 1d0b7ab into master Jun 9, 2025
7 checks passed
@TxCorpi0x TxCorpi0x deleted the mehdi/golangci-v2-fix branch June 9, 2025 12:33
@TxCorpi0x TxCorpi0x restored the mehdi/golangci-v2-fix branch July 30, 2025 09:23
@TxCorpi0x TxCorpi0x mentioned this pull request Jul 30, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masihyeganeh masihyeganeh masihyeganeh approved these changes

@miladz68 miladz68 miladz68 approved these changes

@ysv ysv ysv left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TxCorpi0x @masihyeganeh @miladz68 @ysv