Skip to content

Remove goreleaser image after build in CI#483

Closed
TxCorpi0x wants to merge 1 commit intomasterfrom
mehdi/remove-image
Closed

Remove goreleaser image after build in CI#483
TxCorpi0x wants to merge 1 commit intomasterfrom
mehdi/remove-image

Conversation

@TxCorpi0x
Copy link
Contributor

@TxCorpi0x TxCorpi0x commented Jun 9, 2025

Description

This removes the image right after building. There is a drawback here, and if multiple dependencies of the same run need the same version of Go, it has to download the goreleaser every time.

To be decided: whether is accepted or define a new stap like PostBuild for the dependencies and remove the goreleaser image there.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@TxCorpi0x TxCorpi0x requested a review from a team as a code owner June 9, 2025 08:07
@TxCorpi0x TxCorpi0x requested review from masihyeganeh, miladz68 and ysv and removed request for a team June 9, 2025 08:07
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @ysv)


a discussion (no related file):
making changes to the crust repo will affect all other repos which is an undesirable outcome. Did you try to force a local build in bridge repo ?

@TxCorpi0x
Copy link
Contributor Author

This PR is going to be a temporary change, it should be removed from the code and replaced with a downloaded binary if the host machine is linux.
This is related to failure in CI in this CoreumBridge PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants