Closed
Conversation
6 tasks
miladz68
suggested changes
Jun 9, 2025
Contributor
miladz68
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @masihyeganeh and @ysv)
a discussion (no related file):
making changes to the crust repo will affect all other repos which is an undesirable outcome. Did you try to force a local build in bridge repo ?
Contributor
Author
|
This PR is going to be a temporary change, it should be removed from the code and replaced with a downloaded binary if the host machine is linux. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the image right after building. There is a drawback here, and if multiple dependencies of the same run need the same version of Go, it has to download the goreleaser every time.
To be decided: whether is accepted or define a new stap like PostBuild for the dependencies and remove the goreleaser image there.
Reviewers checklist:
Authors checklist
This change is