Add approve to asset transfer permissions#325
Add approve to asset transfer permissions#325rossneilson merged 6 commits intoDXgovernance:developfrom
Conversation
4ecf7e0 to
25ebace
Compare
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: 9fa0cff 😎 Browse the preview: https://bafybeibtji32jk3gu2b2zocz4s4pnfkg5tvfmuysljtfcdnmltyrjcts2i.ipfs.cf-ipfs.com |
|
✔️ Storybook deployment is ready! 😎 Browse Storybook: https://bafybeig4rg34zuczx46x264pcvvmrk6huyx33aghua7szwh7hexjkvsjme.ipfs.cf-ipfs.com |
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: f0cbd06 😎 Browse the preview: https://bafybeihwhw4po7uxxiuwhp7usvurqgxrzmue4szty6tsqswfgpqqvckrxm.ipfs.cf-ipfs.com |
|
✔️ Storybook deployment is ready! 😎 Browse Storybook: https://bafybeiboz7vimkiosnnwuqxxt2klmvyuszcrs5amotmh3ejvpbqxzh7tm4.ipfs.cf-ipfs.com |
|
Hey @MiltonTulli, I tried creating Proposal like you did on screen record and I am unable to complete creation, getting some errors in the console permission.mp4 |
src/components/ActionsBuilder/SupportedActions/SetPermissions/SetPermissionsEditor.tsx
Outdated
Show resolved
Hide resolved
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: 3eb77e8 😎 Browse the preview at one of these gateways: |
|
✔️ Storybook deployment is ready! 😎 Browse Storybook: https://bafybeignwznoivtvuluwwv5pf2iheoizsr3etrkq7lob4uerjslprhd7xu.ipfs.cf-ipfs.com |
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: 10ad305 😎 Browse the preview at one of these gateways: |
|
✔️ Storybook deployment is ready! 😎 Browse Storybook: https://bafybeih5zef36ugbplufrm6xzdt5v2zn2ueuqjksmcc33ftmykswxra3le.ipfs.cf-ipfs.com |
dcrescimbeni
left a comment
There was a problem hiding this comment.
Dir a full review of the PR and everything looks and work as expected.
rossneilson
left a comment
There was a problem hiding this comment.
Works perfectly! nice work!
|
Looks good to me! |
Description
Add approval call to asset transfer permission
Closes #203
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
Video
Screen.Recording.2022-09-19.at.12.33.34.mov