Skip to content

Add approve to asset transfer permissions#325

Merged
rossneilson merged 6 commits intoDXgovernance:developfrom
MiltonTulli:feature/approve-asset-transfer
Dec 2, 2022
Merged

Add approve to asset transfer permissions#325
rossneilson merged 6 commits intoDXgovernance:developfrom
MiltonTulli:feature/approve-asset-transfer

Conversation

@MiltonTulli
Copy link
Member

@MiltonTulli MiltonTulli commented Sep 19, 2022

Description

Add approval call to asset transfer permission

Closes #203

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

Video

Screen.Recording.2022-09-19.at.12.33.34.mov

@MiltonTulli MiltonTulli marked this pull request as draft September 19, 2022 17:47
@MiltonTulli MiltonTulli force-pushed the feature/approve-asset-transfer branch from 4ecf7e0 to 25ebace Compare September 19, 2022 19:34
@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: 9fa0cff

😎 Browse the preview: https://bafybeibtji32jk3gu2b2zocz4s4pnfkg5tvfmuysljtfcdnmltyrjcts2i.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeig4rg34zuczx46x264pcvvmrk6huyx33aghua7szwh7hexjkvsjme.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: f0cbd06

😎 Browse the preview: https://bafybeihwhw4po7uxxiuwhp7usvurqgxrzmue4szty6tsqswfgpqqvckrxm.ipfs.cf-ipfs.com

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeiboz7vimkiosnnwuqxxt2klmvyuszcrs5amotmh3ejvpbqxzh7tm4.ipfs.cf-ipfs.com

@MiltonTulli MiltonTulli marked this pull request as ready for review September 19, 2022 21:25
@Filipv95
Copy link
Contributor

Hey @MiltonTulli, I tried creating Proposal like you did on screen record and I am unable to complete creation, getting some errors in the console

permission.mp4

@MiltonTulli MiltonTulli marked this pull request as draft September 20, 2022 18:44
@MiltonTulli MiltonTulli marked this pull request as ready for review September 22, 2022 14:25
@MiltonTulli MiltonTulli requested a review from a team September 23, 2022 13:48
@MiltonTulli MiltonTulli marked this pull request as draft October 31, 2022 01:32
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeignwznoivtvuluwwv5pf2iheoizsr3etrkq7lob4uerjslprhd7xu.ipfs.cf-ipfs.com

@github-actions
Copy link

@github-actions
Copy link

✔️ Storybook deployment is ready!

😎 Browse Storybook: https://bafybeih5zef36ugbplufrm6xzdt5v2zn2ueuqjksmcc33ftmykswxra3le.ipfs.cf-ipfs.com

@MiltonTulli MiltonTulli marked this pull request as ready for review November 29, 2022 18:36
Copy link
Contributor

@dcrescimbeni dcrescimbeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dir a full review of the PR and everything looks and work as expected.

Copy link
Contributor

@rossneilson rossneilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly! nice work!

@rossneilson rossneilson merged commit b6fb035 into DXgovernance:develop Dec 2, 2022
@Filipv95
Copy link
Contributor

Filipv95 commented Dec 8, 2022

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add approve to asset setting permissions

4 participants