Skip to content

Add approve to asset transfer permissions #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossneilson merged 6 commits into from
Dec 2, 2022
Merged

Add approve to asset transfer permissions #325

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea3ee63
include approval action in asset transfer permissions
MiltonTulli Sep 19, 2022
25ebace
change edit mode
MiltonTulli Sep 19, 2022
d0bc569
refactor actionsmodal to acept decodedactions array as submit value
MiltonTulli Sep 19, 2022
f3e1706
Merge branch 'develop' into feature/approve-asset-transfer
MiltonTulli Nov 9, 2022
bb0fb70
use baseCall to spread
MiltonTulli Nov 9, 2022
a6a3c24
Merge branch 'develop' into feature/approve-asset-transfer
MiltonTulli Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'develop' into feature/approve-asset-transfer
  • Loading branch information
@MiltonTulli
MiltonTulli committed Nov 9, 2022
commit f3e17066839dd1fd6b899168e610d0067275c5c6
4 changes: 2 additions & 2 deletions src/components/ActionsBuilder/SupportedActions/RepMint/RepMintEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ export const Mint: React.FC<ActionEditorProps> = ({
}
};

const submitAction = () => {
const submitAction = (values: RepMintFormValues) => {
onSubmit([
{
...decodedCall,
args: {
...decodedCall.args,
to: recipient,
to: values.recipient,
amount: ethers.utils.parseUnits(repAmount.toString()),
},
},
Expand Down
1 change: 1 addition & 0 deletions src/components/ActionsBuilder/SupportedActions/SetPermissions/SetPermissionsEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
ANY_FUNC_SIGNATURE,
ERC20_TRANSFER_SIGNATURE,
ERC20_APPROVE_SIGNATURE,
preventEmptyString,
} from 'utils';
import { resolveUri } from 'utils/url';
import { ActionEditorProps } from '..';
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.