(Aura Designer) Fix health bar indicator colour alpha having no effect in replace mode#61
Closed
Krathe82 wants to merge 1 commit into
Closed
Conversation
…t in replace mode The colour picker's alpha slider was silently dropped — ApplyHealthBar read r, g, b from config.color but never read color[4] / color.a, so the alpha was always 1 regardless of what the user set. Additionally, the underlying health bar texture was unconditionally matched to the AD colour to prevent class-colour OOR bleedthrough. This cancelled the alpha effect: a semi-transparent overlay over an identical-coloured bar looks fully opaque. Fix: only match the texture colour when the overlay is fully opaque (a >= 1). When alpha < 1 the user wants the underlying class colour to show through, so we leave it alone. Also restricts the texture colour match to replace mode only — in tint mode the underlying bar colour is intentionally visible through the semi-transparent overlay (that is how the blend slider works).
Contributor
Author
|
Dropping this — the colour picker alpha is inconsistent with how other indicator types handle opacity (squares, bars, and icons all use a separate Alpha slider rather than the colour picker alpha channel). Will flag to Danders: colour alpha currently has no effect for any indicator type in replace or tint mode; the question is whether to add a dedicated Alpha slider or remove alpha from the colour picker for these indicators since Blend % covers the use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApplyHealthBarreadr, g, bfromconfig.colorbut silently droppedcolor.a, so the overlay was always fully opaque regardless of the alpha setting.a >= 1). Whena < 1the user explicitly wants the underlying bar colour to show through.Indicators.luaportion of PR (Aura Designer) Fix health bar tint indicator not fading correctly when out of range #60.Changes
AuraDesigner/Indicators.lua—ApplyHealthBar:a = color[4] or color.a or 1and use it as the overlay alpha in replace modehbTex:SetVertexColortomode == "replace" and a >= 1Test plan
(PR by Krathe)