(Aura Designer) Fix health bar tint indicator not fading correctly when out of range#60
Closed
Krathe82 wants to merge 1 commit into
Closed
(Aura Designer) Fix health bar tint indicator not fading correctly when out of range#60Krathe82 wants to merge 1 commit into
Krathe82 wants to merge 1 commit into
Conversation
6 tasks
…ic mode In element-specific OOR mode the tintOverlay was fading incorrectly: Replace mode: the overlay's blend is 1.0 so SetAlpha(oorAlpha) worked, but the underlying health bar texture retained class colour and bled through as the overlay faded. Fix: match hbTex vertex colour to the AD colour in replace mode so both layers fade together. Tint mode: SetAlpha(oorAlpha) compounded with the blend baked into SetStatusBarColor, giving blend x oorAlpha effective opacity (e.g. 0.5 x 0.2 = 0.1 -- nearly invisible). Fix: drive opacity via SetStatusBarColor directly so the overlay sits at exactly oorAlpha with no compounding. Also stores healthbarMode, healthbarR/G/B, and healthbarBlend on the AD frame state so UpdateAuraDesignerAppearance can restore the overlay to its configured blend when a unit comes back in range.
Krathe82
force-pushed
the
fix/aura-designer-oor-tint
branch
from
f5f79ab to
98fbd72
Compare
DanderBot
added a commit
that referenced
this pull request
May 11, 2026
…king PR #60 conflicted with PR #62 on the replace-mode hbTex:SetVertexColor block; applied only the non-duplicate parts manually. The state.healthbarMode/R/G/B/Blend writes also fix a latent bug in already-merged PR #62 where adHealthBarMode was read but never written, making the live tint/replace switch gate always fail.
Owner
|
Thanks for the PR! The OOR fade fix is genuinely needed. Heads-up: this conflicts with #62 (merged earlier today) — both PRs add the same As a bonus your state writes also fix a latent bug from #62 where Will ship in the next alpha build. Closing this PR since the changes are already on main. |
Krathe82
pushed a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
…bar* tracking PR DanderBot#60 conflicted with PR DanderBot#62 on the replace-mode hbTex:SetVertexColor block; applied only the non-duplicate parts manually. The state.healthbarMode/R/G/B/Blend writes also fix a latent bug in already-merged PR DanderBot#62 where adHealthBarMode was read but never written, making the live tint/replace switch gate always fail.
Krathe82
pushed a commit
to Krathe82/DandersFrames
that referenced
this pull request
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpdateAuraDesignerAppearance, so it never received OOR alpha in element-specific OOR mode — remaining fully opaque while all other AD indicators faded.blend < 1), so when it fades the underlying health bar fill shows through. That fill still held the unit's class colour (e.g. shaman blue), causing an unwanted colour change instead of a smooth fade. Fixed by matching the health bar texture colour to the AD-configured colour while the indicator is active (adHealthBarActivealready preventsUpdateHealthBarAppearancefrom overwriting it;RevertHealthBarrestores class colour on revert).Changes
AuraDesigner/Indicators.lua—ApplyHealthBar: after setting the tintOverlay colour, also set the main health bar texture vertex colour to the AD colour.Features/ElementAppearance.lua—UpdateAuraDesignerAppearance: extend both theoorEnabledand frame-level branches to handle the tintOverlay. Uses plainSetAlpharather thanApplyOORAlphato avoidSetAlphaFromBooleanon health-linked StatusBars.Test plan
(PR by Krathe)