# Sequence diagram for strengthened URL validation in NFTAvatar image rendering

[Dargon789]

Reviewer's Guide

Strengthens URL validation in the NFTAvatar component to mitigate DOM-based XSS by trimming input, enforcing HTTP(S), requiring a non-empty hostname, and rejecting localhost/private network targets before using the URL as an image source.

Sequence diagram for strengthened URL validation in NFTAvatar image rendering

sequenceDiagram
  actor User
  participant SendNFT as SendNFTComponent
  participant NFTAvatar as NFTAvatarComponent
  participant Validator as isValidHttpUrl
  participant Img as ImageElement

  User->>SendNFT: Provide NFT link content
  SendNFT->>NFTAvatar: Pass content prop
  NFTAvatar->>Validator: isValidHttpUrl(content)
  Validator-->>NFTAvatar: true or false
  alt URL is valid HTTP(S) and not local/private
    NFTAvatar->>Img: Set src to content
    Img-->>User: Render NFT image
  else URL invalid or local/private
    NFTAvatar->>Img: Set src to empty string
    Img-->>User: No external image loaded
  end

Loading

File-Level Changes

Change	Details	Files
Harden URL validation helper to defend against DOM-based XSS when using user-controlled URLs as image sources.	Extend isValidHttpUrl to trim input and reject empty strings early Use the trimmed value when constructing the URL object instead of the raw input Keep enforcing HTTP/HTTPS schemes and non-empty hostname requirements Introduce checks to reject localhost and common private IP ranges (127.0.0.1, 10.x.x.x, 192.168.x.x, 172.16–31.x.x)	src/ui/views/Dashboard/components/NFT/NFTAvatar.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

Originally posted by @sourcery-ai[bot] in #35 (comment)