Potential fix for code scanning alert no. 6: Client-side cross-site scripting

[Dargon789]

Potential fix for https://github.com/Dargon789/Rabby/security/code-scanning/6

In general, to fix DOM-based XSS when user input is used as a URL, you must strictly validate and normalize the URL before passing it into any DOM sink (src, href, etc.), and reject or neutralize anything that is not in an explicitly allowed set of schemes, hosts, and formats. Using the platform URL constructor is a good start, but should be combined with an explicit allowlist and, ideally, checks to avoid loading from localhost or private networks if not needed.

For this specific case, the best minimal fix is to strengthen isValidHttpUrl so it not only parses and checks protocol, but also:

• Trims whitespace,
• Ensures a non-empty hostname,
• Optionally rejects localhost / private IP ranges (192.168.x.x, 10.x.x.x, 172.16–31.x.x, 127.0.0.1, etc.) so a crafted link cannot force the app to access internal resources,
• Returns a normalized, safe URL string that the rest of the component uses.

Since we must preserve existing behavior, we’ll keep accepting http and https URLs but introduce an extra guard against internal addresses. To do this cleanly within the shown code, we’ll:

1. Replace the current isValidHttpUrl boolean helper with a stricter version that:
   • Returns false if the URL is not http or https,
   • Uses URL to parse the host and reject obvious local/private targets.
2. Keep using sanitizedUrl = isValidHttpUrl(content) ? content : '' so we don’t have to refactor other code paths.

All changes are local to src/ui/views/Dashboard/components/NFT/NFTAvatar.tsx. src/ui/views/SendNFT/index.tsx does not need to change, because the mitigation is at the sink where the tainted data is consumed.

---

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by Sourcery

Bug Fixes:

• Prevent loading NFT avatar images from invalid, non-HTTP(S), localhost, or common private network URLs by tightening URL validation logic.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[sourcery-ai]

Reviewer's Guide

Strengthens URL validation in the NFTAvatar component to mitigate DOM-based XSS by trimming input, enforcing HTTP(S), requiring a non-empty hostname, and rejecting localhost/private network targets before using the URL as an image source.

Sequence diagram for strengthened URL validation in NFTAvatar image rendering

sequenceDiagram
  actor User
  participant SendNFT as SendNFTComponent
  participant NFTAvatar as NFTAvatarComponent
  participant Validator as isValidHttpUrl
  participant Img as ImageElement

  User->>SendNFT: Provide NFT link content
  SendNFT->>NFTAvatar: Pass content prop
  NFTAvatar->>Validator: isValidHttpUrl(content)
  Validator-->>NFTAvatar: true or false
  alt URL is valid HTTP(S) and not local/private
    NFTAvatar->>Img: Set src to content
    Img-->>User: Render NFT image
  else URL invalid or local/private
    NFTAvatar->>Img: Set src to empty string
    Img-->>User: No external image loaded
  end

Loading

File-Level Changes

Change	Details	Files
Harden URL validation helper to defend against DOM-based XSS when using user-controlled URLs as image sources.	Extend isValidHttpUrl to trim input and reject empty strings early Use the trimmed value when constructing the URL object instead of the raw input Keep enforcing HTTP/HTTPS schemes and non-empty hostname requirements Introduce checks to reject localhost and common private IP ranges (127.0.0.1, 10.x.x.x, 192.168.x.x, 172.16–31.x.x)	src/ui/views/Dashboard/components/NFT/NFTAvatar.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[sourcery-ai]

Hey - I've left some high level feedback:

• The localhost/private network check is quite ad-hoc (e.g., only 127.0.0.1 is blocked but not other 127.* addresses, and IPv6/other loopback formats are ignored); consider centralizing this into a more robust helper that handles full RFC1918 and loopback ranges rather than a few string prefixes.
• If blocking internal/private hosts is a business decision rather than purely a security hardening, it may be worth adding a short comment explaining why these ranges are rejected so future changes don’t inadvertently relax or remove this restriction.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The localhost/private network check is quite ad-hoc (e.g., only `127.0.0.1` is blocked but not other `127.*` addresses, and IPv6/other loopback formats are ignored); consider centralizing this into a more robust helper that handles full RFC1918 and loopback ranges rather than a few string prefixes.
- If blocking internal/private hosts is a business decision rather than purely a security hardening, it may be worth adding a short comment explaining why these ranges are rejected so future changes don’t inadvertently relax or remove this restriction.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}