[Snyk] Fix for 23 vulnerabilities

[Dargon789]

Snyk has created this PR to fix 23 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

• package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning

Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

	Issue
	Regular Expression Denial of Service (ReDoS) SNYK-JS-BABELRUNTIME-10044504
	Buffer Overflow SNYK-JS-BIGINTBUFFER-3364597
	Function Call With Incorrect Argument Type SNYK-JS-CIPHERBASE-12084814
	Prototype Pollution SNYK-JS-LODASH-15053838
	Improper Input Validation SNYK-JS-NANOID-8492085
	Function Call With Incorrect Argument Type SNYK-JS-SHAJS-12089400
	Improper Restriction of Operations within the Bounds of a Memory Buffer SNYK-JS-SOLANAWEB3JS-6647564
	Improper Verification of Cryptographic Signature SNYK-JS-ELLIPTIC-8187303
	Improper Verification of Cryptographic Signature SNYK-JS-ELLIPTIC-7577916
	Improper Verification of Cryptographic Signature SNYK-JS-ELLIPTIC-7577917
	Improper Verification of Cryptographic Signature SNYK-JS-ELLIPTIC-7577918
	Information Exposure SNYK-JS-ELLIPTIC-8720086
	Allocation of Resources Without Limits or Throttling SNYK-JS-QS-14724253
	Improper Validation of Integrity Check Value SNYK-JS-SECP256K1-8237220
	Allocation of Resources Without Limits or Throttling SNYK-JS-QS-15268416
	Prototype Pollution SNYK-JS-WEB3UTILS-6229337
	Denial of Service (DoS) SNYK-JS-WS-7266574
	Symlink Attack SNYK-JS-TMP-11501554
	Use of a Cryptographic Primitive with a Risky Implementation SNYK-JS-ELLIPTIC-14908844
	Missing Release of Resource after Effective Lifetime SNYK-JS-INFLIGHT-6095116
	Improper Verification of Cryptographic Signature SNYK-JS-ELLIPTIC-8172694
	Insufficient Visual Distinction of Homoglyphs Presented to User SNYK-JS-BASEX-10118294
	Regular Expression Denial of Service (ReDoS) SNYK-JS-BRACEEXPANSION-9789073

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Information Exposure
🦉 Prototype Pollution
🦉 More lessons are available in Snyk Learn

[snyk-io]

⚠️ Snyk checks are incomplete.

Status	Scanner	Critical	High	Medium	Low	Total (0)
⚠️	Open Source Security	0	0	0	0	See details

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to significantly enhance the project's security posture by resolving 23 identified vulnerabilities within its yarn dependencies. The changes involve upgrading several key packages to their secure versions, thereby mitigating various risks. It's important to note that a manual update of the yarn.lock file is necessary to fully integrate these security fixes.

Highlights

• Vulnerability Fixes: Addressed 23 security vulnerabilities across various dependencies, including critical and high-severity issues like Function Call With Incorrect Argument Type, Buffer Overflow, and Improper Verification of Cryptographic Signature.
• Dependency Upgrades: Updated multiple package versions in package.json to their secure versions, including major version bumps for ethers, patch-package, and web3-eth-abi.
• Manual yarn.lock Update Required: The yarn.lock file could not be automatically updated by Snyk and requires manual intervention to ensure all dependency resolutions are correctly applied.

Changelog

• package.json
  • Upgraded @coinbase/wallet-sdk from 3.8.0-beta.3 to 3.9.0.
  • Upgraded @eth-optimism/contracts from 0.5.32 to 0.5.34.
  • Upgraded @keystonehq/hw-app-eth from 0.4.4 to 0.5.0.
  • Upgraded @keystonehq/metamask-airgapped-keyring from 0.15.1 to 0.15.2.
  • Upgraded ethers from 5.8.0 to 6.0.0.
  • Upgraded lodash from 4.17.21 to 4.17.23.
  • Upgraded nanoid from 3.3.6 to 3.3.8.
  • Upgraded patch-package from 6.4.7 to 8.0.1.
  • Upgraded web3-eth-abi from 1.7.0 to 4.1.3.

Activity

• This pull request was automatically created by Snyk to address security vulnerabilities.
• Snyk reported that the yarn.lock file failed to update and requires manual intervention.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request from Snyk aims to fix 23 vulnerabilities by upgrading dependencies. However, it introduces several critical issues. Most importantly, it upgrades ethers from version 5 to 6, which is a major update with significant breaking changes. The codebase still uses ethers v5 APIs (e.g., ethers.providers.Web3Provider, ethers.utils) which will cause the application to break. These incompatibilities must be resolved before merging. Additionally, the PR description warns that yarn.lock has not been updated. This is a critical step to ensure consistent dependency resolution and must be done before merging. Lastly, the upgrade of patch-package to v8 likely requires the removal of the postinstall-postinstall dependency. Due to these issues, this PR is not safe to merge as is.

[gemini-code-assist]

Upgrading ethers from v5 to v6 is a major version bump with significant breaking changes. The codebase contains multiple usages of ethers v5 APIs that are now deprecated or removed in v6, which will lead to runtime errors. For example, ethers.providers.Web3Provider is now ethers.BrowserProvider, and the ethers.utils namespace has been removed. The codebase must be refactored to be compatible with ethers v6 before this upgrade can be safely merged.

[gemini-code-assist]

Upgrading web3-eth-abi from v1.7.0 to v4.1.3 is a major version jump that includes breaking changes. The usage of this library in src/background/controller/wallet.ts with ((abiCoder as unknown) as AbiCoder).encodeFunctionCall(...) is unconventional and likely to break with this new version. This needs to be verified and updated to use the v4 API correctly, which typically would be abiCoder.encodeFunctionCall(...) as the default export is now an instance.

[gemini-code-assist]

With the upgrade of patch-package to v8, the postinstall-postinstall package is no longer necessary and should be removed from devDependencies to align with the new version's recommended setup.