Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,23 +30,23 @@
"@aave/contract-helpers": "1.36.1",
"@aave/math-utils": "1.36.1",
"@bgd-labs/aave-address-book": "4.36.0",
"@coinbase/wallet-sdk": "3.8.0-beta.3",
"@coinbase/wallet-sdk": "3.9.0",
"@debank/common": "0.3.60",
"@debank/festats": "1.0.1",
"@dnd-kit/core": "5.0.1",
"@dnd-kit/sortable": "6.0.0",
"@dnd-kit/utilities": "3.0.2",
"@eth-optimism/contracts": "0.5.32",
"@eth-optimism/contracts": "0.5.34",
"@eth-optimism/contracts-ts": "0.17.2",
"@ethereumjs/common": "4.4.0",
"@ethereumjs/rlp": "5.0.2",
"@ethereumjs/tx": "5.4.0",
"@ethereumjs/util": "9.1.0",
"@ethereumjs/wallet": "2.0.4",
"@imkey/web3-provider": "1.3.10",
"@keystonehq/hw-app-eth": "0.4.4",
"@keystonehq/hw-app-eth": "0.5.0",
"@keystonehq/hw-transport-webusb": "0.3.2",
"@keystonehq/metamask-airgapped-keyring": "0.15.1",
"@keystonehq/metamask-airgapped-keyring": "0.15.2",
"@ledgerhq/devices": "8.4.4",
"@ledgerhq/hw-app-eth": "6.42.8",
"@ledgerhq/hw-transport-webhid": "6.30.0",
Expand Down Expand Up @@ -107,7 +107,7 @@
"crypto-browserify": "3.12.0",
"dayjs": "1.10.7",
"eth-rpc-errors": "4.0.3",
"ethers": "5.8.0",
"ethers": "6.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading ethers from v5 to v6 is a major version bump with significant breaking changes. The codebase contains multiple usages of ethers v5 APIs that are now deprecated or removed in v6, which will lead to runtime errors. For example, ethers.providers.Web3Provider is now ethers.BrowserProvider, and the ethers.utils namespace has been removed. The codebase must be refactored to be compatible with ethers v6 before this upgrade can be safely merged.

"events": "3.3.0",
"fflate": "0.8.2",
"hdkey": "0.8.0",
Expand All @@ -117,16 +117,16 @@
"interval-promise": "1.4.0",
"koa-compose": "4.1.0",
"lightweight-charts": "5.0.8",
"lodash": "4.17.21",
"lodash": "4.17.23",
"loglevel": "1.7.1",
"lottie-react": "2.4.0",
"lru-cache": "6.0.0",
"multiformats": "13.3.2",
"nanoid": "3.3.6",
"nanoid": "3.3.8",
"obs-store": "4.0.3",
"p-queue": "7.3.0",
"p-retry": "5.1.2",
"patch-package": "6.4.7",
"patch-package": "8.0.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the upgrade of patch-package to v8, the postinstall-postinstall package is no longer necessary and should be removed from devDependencies to align with the new version's recommended setup.

"postinstall-postinstall": "2.1.0",
"process": "0.11.10",
"qrcode.react": "3.1.0",
Expand Down Expand Up @@ -155,7 +155,7 @@
"url": "0.11.3",
"uuid": "9.0.0",
"viem": "2.23.15",
"web3-eth-abi": "1.7.0",
"web3-eth-abi": "4.1.3",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading web3-eth-abi from v1.7.0 to v4.1.3 is a major version jump that includes breaking changes. The usage of this library in src/background/controller/wallet.ts with ((abiCoder as unknown) as AbiCoder).encodeFunctionCall(...) is unconventional and likely to break with this new version. This needs to be verified and updated to use the v4 API correctly, which typically would be abiCoder.encodeFunctionCall(...) as the default export is now an instance.

"webextension-polyfill": "0.7.0"
},
"devDependencies": {
Expand Down
Loading