Do not call flush extension after each invocation.#154
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 81.90% 82.07% +0.17%
==========================================
Files 13 13
Lines 884 887 +3
==========================================
+ Hits 724 728 +4
+ Misses 131 129 -2
- Partials 29 30 +1 ☔ View full report in Codecov by Sentry. |
duncanista
approved these changes
Dec 19, 2023
Contributor
duncanista
left a comment
There was a problem hiding this comment.
LGTM – thanks for adding the 1 or true check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Only calls
Flush()on the extension when running in local test mode.See DataDog/datadog-lambda-python#406
Motivation
This cuts runtime duration of a hello world function by about 10%.
Testing Guidelines
Additional Notes
Types of changes
Checklist