Do not call flush extension after each invocation.#406
Merged
Conversation
11 tasks
purple4reina
force-pushed
the
rey.abolofia/del-flush
branch
4 times, most recently
from
b1797fe to
cd30010
Compare
purple4reina
force-pushed
the
rey.abolofia/del-flush
branch
from
cd30010 to
516ded2
Compare
astuyve
approved these changes
Dec 15, 2023
duncanista
approved these changes
Dec 15, 2023
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
LGTM! Let's do an RC to test in self monitoring!
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes call to extension to flush.
Motivation
The extension already knows to flush after each invocation. It also has a bunch of logic to configure an adaptive flushing strategy. Therefore, the call to manually trigger a flush are superfluous.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply