Add support for Cloud integration endpoints#429
Conversation
|
@Ricky-Thomas thanks for working on this! Looks like flake8 tests are failing, can you have a look at that then? |
|
Still a WIP. Working to make most recent failing tests pass. |
Ricky-Thomas
changed the title
nmuesch
left a comment
nmuesch
left a comment
There was a problem hiding this comment.
Overall looks good, thanks for this. Left a few pretty minor comments. Thanks!
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
Massive PR, thanks for the work !!
I inline a bunch of comments, let me know what you think.
gzussa
left a comment
gzussa
left a comment
There was a problem hiding this comment.
Thank you so much for this PR. 💯
Thanks for adding tests as well. more coverage = less issues
Please, also test your changes manually using the SDK.
Made some minor comments below.
|
The most recent refactoring work has surfaced a potential bug in the AWS Update endpoint on our side. I'm digging into this tomorrow and may still change the behavior for that here should I have to modify the endpoint in a way that warrants that. This PR can be considered a WIP still at this time. Thanks! |
|
This PR is now ready for another review. The most recent changes address comments from both @zippolyte and @gzussa. The aforementioned potential bug in the AWS Update endpoint on our side has been fixed. |
gzussa
left a comment
gzussa
left a comment
There was a problem hiding this comment.
Looks good to me overall. I am not convinced with naming conventions tho.
gzussa
left a comment
gzussa
left a comment
There was a problem hiding this comment.
Bravo! 👏 Looks good to me. Let's make sure tests passes.
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ricky-Thomas
dismissed stale reviews from zippolyte and nmuesch
Greg Zussa has approved this above
6 participants
This PR adds the existing Cloud integration endpoints to the python client.