add support for SLOs#453
Merged
platinummonkey merged 15 commits intoDataDog:masterfrom Oct 11, 2019
platinummonkey:service-level-objectives
Merged
add support for SLOs#453platinummonkey merged 15 commits intoDataDog:masterfrom platinummonkey:service-level-objectives
platinummonkey merged 15 commits intoDataDog:masterfrom
platinummonkey:service-level-objectives
Conversation
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
requested changes
Oct 9, 2019
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
Left some comments. Also, it might be worth it adding some dogshell tests as well
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
Contributor
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Commenter does not have sufficient privileges for PR 453 in repo DataDog/datadogpy |
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
this makes dogshell UX better
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…nings-style errors for certain status codes update SLO tests
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
requested changes
Oct 10, 2019
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
Can we test for some error scenarios here please 🙏 ?
Contributor
Author
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
approved these changes
Oct 11, 2019
Contributor
zippolyte
left a comment
zippolyte
left a comment
There was a problem hiding this comment.
LGTM !! Thanks a lot for all this
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
* add support for SLOs * add suppress ApiError on base client for status codes to adapt to warnings-style errors for certain status codes * add test for core client suppression * compat for py3 * helper hack for py3 testing compat
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
* add support for SLOs * add suppress ApiError on base client for status codes to adapt to warnings-style errors for certain status codes * add test for core client suppression * compat for py3 * helper hack for py3 testing compat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Service Level Objectives
MA-434