Skip to content

Add documentation for Service Level Objectives#5542

Merged
apigirl merged 17 commits intomasterfrom
cody/service-level-objectives
Oct 16, 2019
Merged

Add documentation for Service Level Objectives#5542
apigirl merged 17 commits intomasterfrom
cody/service-level-objectives

Conversation

@platinummonkey
Copy link
Copy Markdown
Contributor

@platinummonkey platinummonkey commented Sep 30, 2019

initial commit

need to update some sections and ordering
@platinummonkey
Copy link
Copy Markdown
Contributor Author

platinummonkey commented Sep 30, 2019

TODO:

  • needs icons
  • needs re-ordering of /api docs (is there a tool for this?)

@platinummonkey platinummonkey marked this pull request as ready for review September 30, 2019 21:51
@platinummonkey platinummonkey requested a review from a team as a code owner September 30, 2019 21:51
@l0k0ms l0k0ms added the monitors Content changed in the monitors folder label Oct 1, 2019
@l0k0ms
Copy link
Copy Markdown
Contributor

l0k0ms commented Oct 1, 2019

@platinummonkey I fixed the API behavior + added placeholders for PY and RB code examples.

@platinummonkey
Copy link
Copy Markdown
Contributor Author

related: datadogpy PR DataDog/datadogpy#453

@platinummonkey
Copy link
Copy Markdown
Contributor Author

related: dogapi-rb PR DataDog/dogapi-rb#188

@meghanelizabeth
Copy link
Copy Markdown
Contributor

assuming this is the required icon? https://cl.ly/997f18ab3796

@meghanelizabeth
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

@meghanelizabeth meghanelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@platinummonkey
Copy link
Copy Markdown
Contributor Author

should be fixed @meghanelizabeth also doc team is going to remerge back to a sub of monitors

Copy link
Copy Markdown
Contributor

@apigirl apigirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review @meghanelizabeth

@apigirl apigirl added the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 1, 2019
Copy link
Copy Markdown
Contributor Author

@platinummonkey platinummonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add additional links back to the API docs?

@platinummonkey
Copy link
Copy Markdown
Contributor Author

bump @apigirl can we get this finalized for release?

@apigirl apigirl removed the WORK IN PROGRESS No review needed, it's a wip ;) label Oct 16, 2019
@apigirl apigirl merged commit 7b84d33 into master Oct 16, 2019
@apigirl apigirl deleted the cody/service-level-objectives branch October 16, 2019 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

monitors Content changed in the monitors folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants