Fix potential metric loss when open_buffer is combined with disable_buffering=False#820
Merged
Fix potential metric loss when open_buffer is combined with disable_buffering=False#820
Conversation
When disable_buffering=False, the buffer may contain still unsent metrics, which are lost when we reset the buffer. When disable_buffering=True, the reset is a noop anyway.
Even if disable_buffering defaults to False, the user may still opt to disable it, in which case the code in these methods still must execute as it is today.
vickenty
added
the
changelog/Fixed
rayz
approved these changes
Mar 15, 2024
KowalskiThomas
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix potential metric loss when open_buffer is combined with disable_buffering=False.
Description of the Change
Remove call to
_reset_bufferfromopen_buffer.When disable_buffering=False, the buffer may contain still unsent metrics, which are lost when we reset the buffer.
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.