Apollo: README.md and manifest.json fixes#551
Merged
hithwen merged 2 commits intoDataDog:masterfrom Mar 9, 2020
Merged
Conversation
hithwen
approved these changes
Mar 9, 2020
4 tasks
hithwen
reviewed
Oct 1, 2020
| "manifest_version": "1.1.0", | ||
| "maintainer": "sachin@apollographql.com", | ||
| "display_name": "Apollo Engine", | ||
| "display_name": "Apollo", |
Contributor
There was a problem hiding this comment.
Sorry, this cannot be changed, reverting in #728
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the following changes:
display_namefrom"Apollo Engine"to"Apollo"Motivation
For some context, we rebranded the product previously known as "Apollo Engine", and would prefer to use "Apollo" instead of "Apollo Engine" as the display name. (This is also why the readme no longer refers to "Apollo Engine").
Review checklist
no-changeloglabel attached