Skip to content

Apollo: README.md and manifest.json fixes #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hithwen merged 2 commits into from
Mar 9, 2020
Merged

Apollo: README.md and manifest.json fixes #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1687c0d
Update docs URL and fix typo
sachindshinde Mar 5, 2020
77e9630
Change manifest display_name to Apollo
sachindshinde Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apollo/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ The Datadog metrics forwarded by Graph Manager are:

All metrics forwarded to Datadog are aggregated in 60-second intervals and tagged with the GraphQL operation name as `operation:<QUERY_NAME>`. Unique query signatures with the same operation name are merged, and queries without an operation name are ignored.

All of the metrics are also tagged with the Graph Manager graph ID as `service:<GRAPH_ID>` and the variant name as `variant:<VARIAN_NAME>`, so multiple graphs from Graph Manager can send data to the same Datadog account. If you have not set a variant name, then "current" will be used.
All of the metrics are also tagged with the Graph Manager graph ID as `service:<GRAPH_ID>` and the variant name as `variant:<VARIANT_NAME>`, so multiple graphs from Graph Manager can send data to the same Datadog account. If you have not set a variant name, then "current" will be used.

If you're reporting metrics to Graph Manager through the Engine proxy, Datadog will merge your statistics across multiple instances of the proxy (per-host metrics are not available). Just like in the Graph Manager UI, each operation inside a query batch is counted individually.

Expand Down Expand Up @@ -78,7 +78,7 @@ Learn more about infrastructure monitoring and all our integrations on [our blog
[4]: https://www.apollographql.com/docs/graph-manager/#viewing-graph-information
[5]: https://raw.githubusercontent.com/DataDog/integrations-extras/master/apollo/images/settings-link.png
[6]: https://raw.githubusercontent.com/DataDog/integrations-extras/master/apollo/images/settings-toggle.png
[7]: https://www.apollographql.com/docs/graph-manager/integrations/
[7]: https://www.apollographql.com/docs/graph-manager/datadog-integration/
[8]: https://github.com/DataDog/integrations-extras/blob/master/apollo/metadata.csv
[9]: https://docs.datadoghq.com/help
[10]: https://www.datadoghq.com/blog
2 changes: 1 addition & 1 deletion apollo/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
],
"manifest_version": "1.1.0",
"maintainer": "sachin@apollographql.com",
"display_name": "Apollo Engine",
"display_name": "Apollo",
Copy link
Copy Markdown
Contributor

@hithwen hithwen Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this cannot be changed, reverting in #728

"short_description": "Monitor the performance of your GraphQL infrastructure",
"metric_prefix": "apollo.engine.",
"metric_to_check": "apollo.engine.operations.count",
Expand Down