chore: bump libdd-capabilities-impl to 1.1.0 and libdd-data-pipeline to 3.1.0#1989
chore: bump libdd-capabilities-impl to 1.1.0 and libdd-data-pipeline to 3.1.0#1989mabdinur wants to merge 1 commit into
Conversation
…to 3.1.0 Bumps two crates that added public APIs without a version increment, so they can be published to crates.io and consumed without [patch.crates-io]: - libdd-capabilities-impl 1.0.0 → 1.1.0 (adds NativeCapabilities) - libdd-data-pipeline 3.0.1 → 3.1.0 (adds telemetry feature, TelemetryInstrumentationSessions, generic TraceExporter<C>) libdd-telemetry is already at 5.0.0 on main (unpublished), so no bump needed. Required by dd-trace-rs to use instrumentation session ID propagation without a [patch.crates-io] workaround. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Point to the published crate versions from DataDog/libdatadog#1989: libdd-data-pipeline 3.0.1 → 3.1.0 libdd-telemetry 4.0.0 → 5.0.0 libdd-capabilities-impl 1.0.0 → 1.1.0 These versions include the APIs required for instrumentation session ID propagation (TelemetryInstrumentationSessions, NativeCapabilities, session_id fields on telemetry Config). With them published, the [patch.crates-io] git overrides are no longer needed and are removed from both Cargo.toml and instrumentation/Cargo.toml. Note: this commit will not build until libdatadog#1989 merges and the new crate versions are published to crates.io. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3597a157c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [package] | ||
| name = "libdd-data-pipeline" | ||
| version= "3.0.1" | ||
| version= "3.1.0" |
There was a problem hiding this comment.
Update the workspace lockfile with the version bump
When this package version is changed without the root Cargo.lock update, locked builds no longer resolve the workspace: I checked cargo check --locked -p libdd-data-pipeline --no-default-features and it exits with the lock file /workspace/libdatadog/Cargo.lock needs to be updated. Any CI/release job or developer build that uses the checked-in lockfile with --locked will fail until the lockfile records libdd-data-pipeline 3.1.0 and libdd-capabilities-impl 1.1.0.
Useful? React with 👍 / 👎.
📚 Documentation Check Results📦
|
🔒 Cargo Deny Results📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1989 +/- ##
==========================================
+ Coverage 72.63% 72.66% +0.02%
==========================================
Files 451 451
Lines 74687 74687
==========================================
+ Hits 54249 54268 +19
+ Misses 20438 20419 -19
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 3597a15 | Docs | Datadog PR Page | Give us feedback! |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
@ekump Thanks 🙏 . I'll move this to draft |
|
👋 it turns out that:
so, I have discovered why the check is failing and I have a fix here This PR should be closed |
|
Awesome! Thanks @iunanua 🙇 |
@mabdinur all the crates you need have been published https://github.com/DataDog/libdatadog/tags |
What does this PR do?
Bumps two crates that added public APIs in #1822 without incrementing their version numbers. Without a version bump these APIs cannot be published to crates.io (you cannot republish the same version), blocking downstream consumers from using them without a
[patch.crates-io]workaround.libdd-capabilities-impl1.0.01.1.0NativeCapabilitieslibdd-data-pipeline3.0.13.1.0telemetryfeature,TelemetryInstrumentationSessions,TraceExporter<C>libdd-telemetryis already at5.0.0on main (unpublished), so no bump is needed there.Motivation
dd-trace-rs#216 implements instrumentation session ID propagation using these APIs. Until this PR lands and these crates are published,dd-trace-rsmust carry a[patch.crates-io]block in every workspace that consumes it — includingDataDog/system-testsfor parametric tests.After merge
Once this PR is merged, publish
libdd-capabilities-impl 1.1.0andlibdd-data-pipeline 3.1.0to crates.io (along with the already-bumpedlibdd-telemetry 5.0.0). Thendd-trace-rsPR #216 can be updated to reference the published versions and drop[patch.crates-io]entirely.