Skip to content

Feature(profiling-replayer): Implement memory tracking#216

Merged
morrisonlevi merged 1 commit into
levi/pprof-replayerfrom
dsn/pprof-replayer-mem
Aug 14, 2023
Merged

Feature(profiling-replayer): Implement memory tracking#216
morrisonlevi merged 1 commit into
levi/pprof-replayerfrom
dsn/pprof-replayer-mem

Conversation

@danielsn
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds memory tracking to the profiling-replayer, via a -m or --mem flag.

Motivation

The first step towards optimizing memory is knowing how much we're actually using.

Additional Notes

At least on mac, the reported memory usage seems quite noisy. For two consecuative runs:

Memory usage (kB)
Before adding samples:  102678
After adding samples:   104792  Delta: 2113
After serializing:      119209  Delta: 14417
...
Memory usage (kB)
Before adding samples:  101974
After adding samples:   105332  Delta: 3358
After serializing:      118603  Delta: 13271

How to test the change?

run the profiler as before, but also pass the -m flag.

@danielsn danielsn requested review from a team as code owners August 14, 2023 19:32
@morrisonlevi morrisonlevi merged commit 78e4198 into levi/pprof-replayer Aug 14, 2023
@morrisonlevi morrisonlevi deleted the dsn/pprof-replayer-mem branch August 14, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants