Skip to content

Decorate every tests with known feature ids#1910

Merged
cbeauchesne merged 2 commits into
mainfrom
cbeauchesne/features-ids
Dec 11, 2023
Merged

Decorate every tests with known feature ids#1910
cbeauchesne merged 2 commits into
mainfrom
cbeauchesne/features-ids

Conversation

@cbeauchesne
Copy link
Copy Markdown
Collaborator

@cbeauchesne cbeauchesne commented Dec 11, 2023

Description

Decorate every tests with known feature ids

Motivation

Use the new feature association mechanism

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@cbeauchesne cbeauchesne marked this pull request as ready for review December 11, 2023 13:35
@cbeauchesne cbeauchesne requested review from a team as code owners December 11, 2023 13:35
@cbeauchesne cbeauchesne merged commit 232d30b into main Dec 11, 2023
@cbeauchesne cbeauchesne deleted the cbeauchesne/features-ids branch December 11, 2023 17:21
khanayan123 added a commit that referenced this pull request May 12, 2026
@khanayan123 @claude
Enable Test_ExtendedHeartbeat for php >=1.20.0
d1cd94d 
Both upstream blockers landed:

- libdatadog v33.0.0 (2026-05-07) includes #1910 "schedule
  ExtendedHeartbeat on worker start" — the sidecar now actually emits
  the event.
- dd-trace-php#3865 (merged 2026-05-11) bumped the libdatadog
  submodule past v33.0.0 to also include #1962 "include dependencies
  and integrations in app-extended-heartbeat".

#3865 is post-1.19.2, so gate at >=1.20.0 (the next release).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

run-all-scenarios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cbeauchesne