Fix tests/appsec/test_conf.py#3865
Merged
Merged
Conversation
8283d31 to
031348c
Compare
cbeauchesne
approved these changes
Jan 24, 2025
robertomonteromiguel
pushed a commit
that referenced
this pull request
Mar 17, 2025
Co-authored-by: Charles de Beauchesne <charles.de.beauchesne@gmail.com> Motivation Fix easy wins in tests/appsec/test_conf.py: test_disabled test_waf_timeout The tests were unreliable as they only checked for the absence of an AppSec event, this is not enough as an unimplemented endpoint or a bad request pass the test For instance the intention in test_waf_timeout is to verify that there is no event because of a timeout in the WAF. Instead, the requests were malformed, leading to errors (various 400s) and not being processed correctly. Changes test_disabled Added a status check for the response to ensure the request is valid and the endpoint is implemented. Excluded Sinatra variants in Ruby, which were causing 404 errors. test_waf_timeout Added a status check for the response to ensure the request is valid and the endpoint is implemented. Excluded Sinatra variants in Ruby, which were causing 404 errors. Modified the payload to: Reduce the URL length and number of headers (the main issue with many frameworks). Increase WAF load by matching more rules. Modify scenario to be able to set python to 1 microsecond (as python waf timeout is configured in milliseconds instead of microseconds)
khanayan123
added a commit
that referenced
this pull request
May 12, 2026
Both upstream blockers landed: - libdatadog v33.0.0 (2026-05-07) includes #1910 "schedule ExtendedHeartbeat on worker start" — the sidecar now actually emits the event. - dd-trace-php#3865 (merged 2026-05-11) bumped the libdatadog submodule past v33.0.0 to also include #1962 "include dependencies and integrations in app-extended-heartbeat". #3865 is post-1.19.2, so gate at >=1.20.0 (the next release). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix easy wins in tests/appsec/test_conf.py:
The tests were unreliable as they only checked for the absence of an AppSec event, this is not enough as an unimplemented endpoint or a bad request pass the test
For instance the intention in test_waf_timeout is to verify that there is no event because of a timeout in the WAF. Instead, the requests were malformed, leading to errors (various 400s) and not being processed correctly.
APPSEC-54879
Changes
test_disabled
test_waf_timeout
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present