feat: integrate uniswap v3 - #3545
Merged
Merged
Conversation
guanbinrui
marked this pull request as draft
July 1, 2021 06:31
septs
previously approved these changes
Jul 1, 2021
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
2 times, most recently
from
July 1, 2021 07:25
379e795 to
c3fe738
Compare
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
July 7, 2021 13:22
bdb2d1a to
cb1a640
Compare
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
July 10, 2021 08:15
cb1a640 to
7260872
Compare
septs
reviewed
Jul 11, 2021
| @@ -5,5 +5,5 @@ import type { AbiItem } from 'web3-utils' | |||
|
|
|||
| export function useQuoterContract() { | |||
Contributor
There was a problem hiding this comment.
@guanbinrui suggest, abstract a contract hook factory method
design a such factory method
const useQuoterContract = makeContractHook<Quoter>({
abi: QuoterABI,
useAddress: () => useTraderConstants().UNISWAP_V3_QUOTER_ADDRESS,
})
Contributor
There was a problem hiding this comment.
Let's keep it stupid and simple (KISS) first. 😄
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
July 11, 2021 14:53
804ed7d to
324599d
Compare
guanbinrui
commented
Jul 12, 2021
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
July 12, 2021 01:24
324599d to
6e72806
Compare
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
July 12, 2021 01:50
6e72806 to
7517589
Compare
septs
reviewed
Jul 12, 2021
septs
reviewed
Jul 12, 2021
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
July 12, 2021 03:56
1cbc808 to
750873c
Compare
github-actions
Bot
added
Blocked: Has Conflict
and removed
Blocked: Has Conflict
labels
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
July 23, 2021 03:10
ad70d74 to
b946450
Compare
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
July 23, 2021 03:12
b946450 to
b90ba5a
Compare
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
August 10, 2021 06:25
f7823c6 to
35c1346
Compare
* fix: rename *TOLERANCE* to *SETTINGS* * fix: break a long expression into two
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
August 10, 2021 07:48
df64884 to
59e4848
Compare
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
August 10, 2021 08:02
d6f64c8 to
9836019
Compare
septs
previously approved these changes
Aug 13, 2021
lelenei
previously approved these changes
Aug 13, 2021
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
August 13, 2021 06:21
479bde6 to
c43de36
Compare
UncleBill
previously approved these changes
Aug 13, 2021
Jack-Works
reviewed
Aug 13, 2021
| '@masknet/plugin-wallet': require.resolve('../plugins/Wallet/src/index.ts'), | ||
| '@masknet/external-plugin-previewer': require.resolve('../external-plugin-previewer/src/index.tsx'), | ||
| '@masknet/web3-shared': require.resolve('../web3-shared/src/index.ts'), | ||
| '@uniswap/v3-sdk': require.resolve('@uniswap/v3-sdk/dist/index.js'), |
Member
Author
There was a problem hiding this comment.
The original ES module uses an unsupported import statement.
Learn more: Uniswap/v3-sdk#51
Member
There was a problem hiding this comment.
Can you remember to revert this change after they fix this problem?
guanbinrui
force-pushed
the
feature/uniswap-v3
branch
from
August 13, 2021 08:35
12be92d to
0dd0fe1
Compare
Jack-Works
approved these changes
Aug 13, 2021
yanzhihong23
added a commit
that referenced
this pull request
Aug 13, 2021
* develop: feat: integrate uniswap v3 (#3545) docs(i18n): sync i18n files from Crowdin (#3946) feat(twitter): add an NFT tab in profile page (#3804) fix: icon filter conflict (#3940) chore: update crowdin integration chore: update crowdin integration chore: update crowdin integration fix: css breaks (#3939) Update Crowdin configuration file refactor: snapshot api (#3938) feat: update zerion get asset api for evm chain (#3928)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3091