Skip to content

feat(twitter): add an NFT tab in profile page - #3804

Merged
guanbinrui merged 64 commits into
developfrom
lelenei/fix-3751
Aug 13, 2021
Merged

feat(twitter): add an NFT tab in profile page#3804
guanbinrui merged 64 commits into
developfrom
lelenei/fix-3751

Conversation

@lelenei

@lelenei lelenei commented Jul 30, 2021

Copy link
Copy Markdown
Contributor

closes #3751
closes #3767
closes #3808

@lelenei
lelenei requested a review from Jack-Works July 30, 2021 04:23
@septs

septs commented Jul 30, 2021

Copy link
Copy Markdown
Contributor

plz rename this pr title, thanks

@lelenei lelenei changed the title Lelenei/fix 3751 Enhance tab list on the profile page Jul 30, 2021
@lelenei
lelenei marked this pull request as draft July 30, 2021 05:33
@UncleBill UncleBill changed the title Enhance tab list on the profile page feat(twitter): Add NFT tab in profile page Jul 30, 2021
@UncleBill UncleBill changed the title feat(twitter): Add NFT tab in profile page feat(twitter): add NFT tab in profile page Jul 30, 2021
@UncleBill

This comment has been minimized.

@UncleBill UncleBill changed the title feat(twitter): add NFT tab in profile page feat(twitter): add a NFT tab in profile page Aug 2, 2021
@UncleBill
UncleBill marked this pull request as ready for review August 2, 2021 02:48
Comment thread packages/maskbook/src/social-network/types.ts Outdated
@Jack-Works
Jack-Works marked this pull request as draft August 2, 2021 03:03
@UncleBill UncleBill changed the title feat(twitter): add a NFT tab in profile page feat(twitter): add an NFT tab in profile page Aug 3, 2021
Comment thread packages/web3-shared/src/hooks/useResolveEns.ts Outdated
@guanbinrui
guanbinrui marked this pull request as ready for review August 4, 2021 02:51
@UncleBill

Copy link
Copy Markdown
Contributor

@DimensionDev/qa It's ready for test.

@Jack-Works

Copy link
Copy Markdown
Member

@DimensionDev/qa It's ready for test.

Please wait for my review before merge thanks!!

Jack-Works
Jack-Works previously approved these changes Aug 10, 2021
@septs

septs commented Aug 10, 2021

Copy link
Copy Markdown
Contributor

plz resolve conflict

Comment thread packages/maskbook/src/social-network-adaptor/twitter.com/utils/selector.ts Outdated
Jack-Works
Jack-Works previously approved these changes Aug 13, 2021
Comment thread packages/maskbook/src/components/InjectedComponents/EnhancedProfile.tsx Outdated
Jack-Works
Jack-Works previously approved these changes Aug 13, 2021
guanbinrui
guanbinrui previously approved these changes Aug 13, 2021
},
line: {
dispaly: 'inline-flex',
borderRadius: 9999,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 100%?

@guanbinrui
guanbinrui merged commit c591790 into develop Aug 13, 2021
@guanbinrui
guanbinrui deleted the lelenei/fix-3751 branch August 13, 2021 08:03
yanzhihong23 added a commit that referenced this pull request Aug 13, 2021
* develop:
  feat: integrate uniswap v3 (#3545)
  docs(i18n): sync i18n files from Crowdin (#3946)
  feat(twitter): add an NFT tab in profile page (#3804)
  fix: icon filter conflict (#3940)
  chore: update crowdin integration
  chore: update crowdin integration
  chore: update crowdin integration
  fix: css breaks (#3939)
  Update Crowdin configuration file
  refactor: snapshot api (#3938)
  feat: update zerion get asset api for evm chain (#3928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Demand] Add an NFTs tab on profile page [Demand] Add twitter identifier resolve service [Demand] Enhance tab list on the profile page

5 participants