feat(web3-shared): add useResolveEns for resolving ens - #3793
Closed
UncleBill wants to merge 2 commits into
Closed
Conversation
guanbinrui
reviewed
Jul 29, 2021
UncleBill
force-pushed
the
feat/add-hook-to-resolve-ens
branch
from
July 30, 2021 02:07
2354c59 to
7e4c845
Compare
UncleBill
requested review from
Jack-Works,
Lanttcat,
guanbinrui,
hanszhoou and
nuanyang233
July 30, 2021 02:11
guanbinrui
reviewed
Jul 30, 2021
| const web3 = useWeb3() | ||
|
|
||
| return useAsyncRetry(async () => { | ||
| return await web3.eth.ens.getAddress(name) |
Member
There was a problem hiding this comment.
- Test with Maskbook provider.
- Test with MetaMask provider.
- Test with WalletConnect provider.
Should a new RPC method be added into network.ts?
Contributor
Author
|
Will come along with #3804. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get the address of vgod (vitalik.eth)
part of #3767