Skip to content

fix: dialog ui issues - #4881

Merged
guanbinrui merged 12 commits into
developfrom
fix/issue4877
Nov 23, 2021
Merged

fix: dialog ui issues#4881
guanbinrui merged 12 commits into
developfrom
fix/issue4877

Conversation

@BillySh1

Copy link
Copy Markdown
Contributor

closes #4877

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@github-actions

github-actions Bot commented Nov 22, 2021

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request November 22, 2021 10:24 Inactive
@septs

septs commented Nov 22, 2021

Copy link
Copy Markdown
Contributor

plz rename the pr title, thanks

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@BillySh1 BillySh1 changed the title Fix/issue4877 fix: dialog ui issues Nov 23, 2021
@BillySh1 BillySh1 closed this Nov 23, 2021
@BillySh1 BillySh1 reopened this Nov 23, 2021
@github-actions
github-actions Bot temporarily deployed to pull request November 23, 2021 07:40 Inactive
@BillySh1
BillySh1 requested a review from Lanttcat November 23, 2021 07:42
@github-actions
github-actions Bot temporarily deployed to pull request November 23, 2021 07:42 Inactive
@wenluomask

Copy link
Copy Markdown
Contributor

Checked.

@BillySh1
BillySh1 requested a review from guanbinrui November 23, 2021 09:26
<section className={classes.currentAccount}>
<section
className={
props.isDashboard ? `${classes.currentAccount} ${classes.dashboardBackground}` : classes.currentAccount

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import classNames from 'classnames'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions
github-actions Bot temporarily deployed to pull request November 23, 2021 09:40 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request November 23, 2021 09:49 Inactive
@github-actions
github-actions Bot temporarily deployed to pull request November 23, 2021 10:02 Inactive
@BillySh1
BillySh1 requested a review from guanbinrui November 23, 2021 10:07
@BillySh1
BillySh1 requested review from Lanttcat and removed request for wenluomask and xiazhiming November 23, 2021 10:08
@guanbinrui
guanbinrui merged commit 16489c8 into develop Nov 23, 2021
@guanbinrui
guanbinrui deleted the fix/issue4877 branch November 23, 2021 10:11
yanzhihong23 added a commit that referenced this pull request Nov 24, 2021
* develop:
  fix: add variant: constained to some buttons (#4911)
  refactor: remove unused code (#4905)
  chore: introduce @masknet/web3-providers (#4903)
  fix: nft cache name (#4901)
  fix: select wallet page is empty (#4883)
  feat: remove swap settings in labs page (#4890)
  fix: dialog ui issues (#4881)
  feat: implement getFungibleAssets of flow chain (#4879)

# Conflicts:
#	packages/dashboard/src/pages/Labs/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Make UI adjustment for change network page for Dashboard

5 participants