Skip to content

fix: add variant: constained to some buttons - #4911

Merged
guanbinrui merged 17 commits into
developfrom
fix/btn-background
Nov 24, 2021
Merged

fix: add variant: constained to some buttons#4911
guanbinrui merged 17 commits into
developfrom
fix/btn-background

Conversation

@BillySh1

Copy link
Copy Markdown
Contributor

closes #4889

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@BillySh1 BillySh1 closed this Nov 24, 2021
@BillySh1 BillySh1 reopened this Nov 24, 2021
@github-actions

github-actions Bot commented Nov 24, 2021

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request November 24, 2021 06:25 Inactive
@BillySh1
BillySh1 requested a review from Lanttcat November 24, 2021 06:25
@github-actions
github-actions Bot temporarily deployed to pull request November 24, 2021 06:28 Inactive
Jack-Works
Jack-Works previously approved these changes Nov 24, 2021
@github-actions
github-actions Bot temporarily deployed to pull request November 24, 2021 07:43 Inactive
Lanttcat
Lanttcat previously approved these changes Nov 24, 2021
@github-actions
github-actions Bot temporarily deployed to pull request November 24, 2021 08:15 Inactive
@BillySh1
BillySh1 requested a review from Jack-Works November 24, 2021 08:16
Jack-Works
Jack-Works previously approved these changes Nov 24, 2021
@BillySh1
BillySh1 enabled auto-merge (squash) November 24, 2021 08:22
@BillySh1
BillySh1 disabled auto-merge November 24, 2021 08:22
@BillySh1
BillySh1 dismissed stale reviews from Jack-Works and Lanttcat via b8585fe November 24, 2021 08:29
@github-actions
github-actions Bot temporarily deployed to pull request November 24, 2021 08:34 Inactive
@BillySh1
BillySh1 requested a review from hanszhoou November 24, 2021 08:48
@hanszhoou

Copy link
Copy Markdown
Contributor

@BillySh1 Have you confirmed that adding these variant="contained" would meet the design?

@guanbinrui
guanbinrui merged commit abab4ad into develop Nov 24, 2021
@guanbinrui
guanbinrui deleted the fix/btn-background branch November 24, 2021 08:59
@BillySh1

Copy link
Copy Markdown
Contributor Author

yes checked by wen.luo

yanzhihong23 added a commit that referenced this pull request Nov 24, 2021
* develop:
  fix: add variant: constained to some buttons (#4911)
  refactor: remove unused code (#4905)
  chore: introduce @masknet/web3-providers (#4903)
  fix: nft cache name (#4901)
  fix: select wallet page is empty (#4883)
  feat: remove swap settings in labs page (#4890)
  fix: dialog ui issues (#4881)
  feat: implement getFungibleAssets of flow chain (#4879)

# Conflicts:
#	packages/dashboard/src/pages/Labs/index.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Add background color to some buttons in Dashboard

5 participants