Skip to content

fix: rename dialog title - #5881

Merged
guanbinrui merged 2 commits into
developfrom
lelenei/mf-40
Mar 23, 2022
Merged

fix: rename dialog title#5881
guanbinrui merged 2 commits into
developfrom
lelenei/mf-40

Conversation

@lelenei

@lelenei lelenei commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

Description

Closes # mf-40

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions

github-actions Bot commented Mar 15, 2022

Copy link
Copy Markdown
Contributor

@github-actions
github-actions Bot temporarily deployed to pull request March 15, 2022 13:16 Inactive
Jack-Works
Jack-Works previously approved these changes Mar 15, 2022
Comment thread packages/mask/src/plugins/Wallet/SNSAdaptor/SelectTokenDialog.tsx Outdated
@wenluomask

Copy link
Copy Markdown
Contributor

Checked.

@guanbinrui

guanbinrui commented Mar 18, 2022

Copy link
Copy Markdown
Member

Checked.

Try to swap any token with this patch on the dashboard page.

@wenluomask

Copy link
Copy Markdown
Contributor

Do you mean swap the token just added? It works.

hanszhoou
hanszhoou previously approved these changes Mar 22, 2022
@guanbinrui

guanbinrui commented Mar 23, 2022

Copy link
Copy Markdown
Member

@lelenei @wenluomask Try to swap a token on the dashboard, and click the select token button. The title should be Select a Token rather than Add a Token.

image

@UncleBill

Copy link
Copy Markdown
Contributor

@lelenei @wenluomask Try to swap a token on the dashboard, and click the select token button. The title should be Select a Token rather than Add a Token.

If we have #5632 merged, it will be simple

pickToken({
  title: 'Add a Token' // or 'Select a Token'
})

@lelenei
lelenei dismissed stale reviews from hanszhoou and Jack-Works via acd729a March 23, 2022 08:11
@github-actions
github-actions Bot temporarily deployed to pull request March 23, 2022 08:16 Inactive
@guanbinrui

Copy link
Copy Markdown
Member

@DimensionDev/qa

@wenluomask

Copy link
Copy Markdown
Contributor

Checked.

@guanbinrui
guanbinrui merged commit 9305569 into develop Mar 23, 2022
@guanbinrui
guanbinrui deleted the lelenei/mf-40 branch March 23, 2022 14:35
nuanyang233 pushed a commit to layinka/Maskbook that referenced this pull request Mar 28, 2022
* fix: rename dialog title

* fix: reply review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants