Skip to content

fix: rename dialog title #5881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guanbinrui merged 2 commits into from
Mar 23, 2022
Merged

fix: rename dialog title #5881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9a03d6
fix: rename dialog title
lelenei Mar 15, 2022
acd729a
fix: reply review
lelenei Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/dashboard/src/pages/Wallets/components/Assets/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export const Assets = memo<TokenAssetsProps>(({ network }) => {
? setSelectToken({
open: true,
uuid: id,
title: t.wallets_add_token(),
FungibleTokenListProps: { whitelist: [] },
})
: setAddCollectibleOpen(true)
Expand Down
8 changes: 3 additions & 5 deletions packages/mask/src/plugins/Wallet/SNSAdaptor/SelectTokenDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export function SelectTokenDialog(props: SelectTokenDialogProps) {
const [targetChainId, setChainId] = useState<ChainId | undefined>(chainId)
const [rowSize, setRowSize] = useState(54)

const [title, setTitle] = useState(t('plugin_wallet_select_a_token'))
const [disableNativeToken, setDisableNativeToken] = useState(true)
const [disableSearchBar, setDisableSearchBar] = useState(false)
const [FungibleTokenListProps, setFungibleTokenListProps] = useState<ERC20TokenListProps | null>(null)
Expand All @@ -71,6 +72,7 @@ export function SelectTokenDialog(props: SelectTokenDialogProps) {

const { open, setDialog } = useRemoteControlledDialog(WalletMessages.events.selectTokenDialogUpdated, (ev) => {
if (!ev.open) return
setTitle(ev.title ?? t('plugin_wallet_select_a_token'))
setId(ev.uuid)
setDisableNativeToken(ev.disableNativeToken ?? true)
setDisableSearchBar(ev.disableSearchBar ?? false)
Expand All @@ -97,11 +99,7 @@ export function SelectTokenDialog(props: SelectTokenDialogProps) {
}, [id, setDialog])

return (
<InjectedDialog
titleBarIconStyle={isDashboard ? 'close' : 'back'}
open={open}
onClose={onClose}
title={t('plugin_wallet_select_a_token')}>
<InjectedDialog titleBarIconStyle={isDashboard ? 'close' : 'back'} open={open} onClose={onClose} title={title}>
<DialogContent classes={{ root: classes.content }}>
<ERC20TokenList
classes={{ list: classes.list, placeholder: classes.placeholder }}
Expand Down
2 changes: 2 additions & 0 deletions packages/plugins/Wallet/src/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export type SelectTokenDialogEvent =
tokens?: FungibleTokenDetailed[]
selectedTokens?: string[]
}
title?: string
}
| {
open: false
Expand All @@ -125,6 +126,7 @@ export type SelectTokenDialogEvent =
* The selected detailed token.
*/
token?: FungibleTokenDetailed
title?: string
}

export type SelectNftContractDialogEvent = {
Expand Down