feat: manage recent pending transactions by UncleBill · Pull Request #6055 · DimensionDev/Maskbook

UncleBill · 2022-04-11T01:52:25Z

https://mask.atlassian.net/browse/MF-278

github-actions · 2022-04-11T01:59:36Z

🚀 Deployed on https://6260b9239e21ec659c30633b--compassionate-northcutt-326a3a.netlify.app

guanbinrui · 2022-04-11T09:16:42Z

+}
+
+const domainAddressMap: Record<string, string[]> = {
+    'uniswap.org': collect(Trader, [


Will these links use for opening in the browser? Lost protocol.

No, there is no such requirement yet.

UncleBill · 2022-04-12T02:24:39Z

@DimensionDev/qa Please help to verify.

guanbinrui · 2022-04-12T09:25:59Z

+    const txData = tx.payload?.params?.[0].data as string | undefined
+    const { value: functionName } = useAsync(async () => {
+        const name = await getContractFunctionName(txData)
+        if (name === TransactionType.CREATE_RED_PACKET) return 'Create Lucky Drop'


What about other TrasnactionType?

It's naming migration.
I have rename the enum, no need to do such fixing anymore.

UncleBill · 2022-04-14T06:22:28Z

@DimensionDev/qa Please help to verify.

guanbinrui · 2022-04-20T02:42:17Z

+        frozenTxes.current = pendingTransactions.slice(0, 2)
+        // trigger rerender in next loop
+        Promise.resolve().then(() => {
+            setMeltedTxHashes([])


Suggested change

setMeltedTxHashes([])

setMeltedTxHashes(EMPTY_LIST)

Need to setState a new array to trigger rerendering.

guanbinrui · 2022-04-20T02:42:49Z

+                    className={classes.transactionList}
+                    transactions={transactions}
+                    onClear={(tx) => {
+                        setMeltedTxHashes((list) => [...list, tx.hash])


Use uniqBy to remove duplicate items.

No need, meltedTxHashes just for checking existing.

nuanyang233 · 2022-04-20T02:58:18Z

-        }
-        return (transaction.type ?? '').replace(/_/g, ' ')
-    }, [transaction.type])
+    const transactionType = (transaction.type ?? '').replace(/_/g, ' ')


Maybe extract format function?

Or maybe we should add a uiName field to Transaction

nuanyang233 · 2022-04-20T15:40:12Z

+    const web3 = useWeb3()
+    const { value: targetAddress } = useAsync(async () => {
+        if (tx.receipt?.contractAddress) return tx.receipt.contractAddress
+        if (tx.payload?.params?.[0].to) return tx.payload.params[0].to as string


You can use the lodash head or first

Access tx.payload.params twice, don't wanna use head twice.

nuanyang233 · 2022-04-20T15:44:29Z

+                        setTxStatus(TransactionStatusType.SUCCEED)
+                    }
+                    break
+                case TransactionStateType.FAILED:


you're missing break, and look like the if(tx.hash === data.receipt.transactionHash) move outside the switch be better.

you're missing break

We can omit it at the final branch

look like the if(tx.hash === data.receipt.transactionHash) move outside the switch be better.

When a TX receipt, it also has receipt.hash

| { type: TransactionStateType.RECEIPT receipt: TransactionReceipt } | { type: TransactionStateType.CONFIRMED no: number receipt: TransactionReceipt reason?: string }

nuanyang233 · 2022-04-20T15:50:45Z

+            </Grid>
+            <Grid item className={classes.cell} flexGrow={1} md={4} justifyContent="right">
+                <Typography variant="body1">
+                    {address && isSameAddress(domain, address) ? Utils?.formatAddress?.(address, 4) : domain || address}


So the domain is an address? If so, I think the name is easy to cause misunderstanding

domainOrAddress

MF-278

* develop: (143 commits) feat: tips entrance (#6012) refactor: remove unused plugin entries chore: patch @solana/web3.js (#6125) New translations en-US.json (Quenya) (#6131) New translations en-US.json (Quenya) (#6126) feat: new intial persona page (#6122) chore: turn on fortmatic (#6127) fix: if phantom is locked, might not able to open its popup (#6115) fix: reduce jsx nested (#6124) fix: duplicate render by unique key (#6123) docs(i18n): sync i18n files from Crowdin (#6119) feat: manage recent pending transactions (#6055) chore: add conflux config (#6112) fix: type error (#6113) feat: improve mask popup (#5986) feat: new app board (#6018) fix(tip): set significant to 6 for formatting max amount (#6062) fix: ITO history default icon (#6078) feat: add <ConcealableTabs /> (#6073) fix: if gulp biuld-ci fails, ci should fail as well (#6107) ...

* develop: (94 commits) fix: mnemonic words exports (#6136) feat: tips entrance (#6012) refactor: remove unused plugin entries chore: patch @solana/web3.js (#6125) New translations en-US.json (Quenya) (#6131) New translations en-US.json (Quenya) (#6126) feat: new intial persona page (#6122) chore: turn on fortmatic (#6127) fix: if phantom is locked, might not able to open its popup (#6115) fix: reduce jsx nested (#6124) fix: duplicate render by unique key (#6123) docs(i18n): sync i18n files from Crowdin (#6119) feat: manage recent pending transactions (#6055) chore: add conflux config (#6112) fix: type error (#6113) feat: improve mask popup (#5986) feat: new app board (#6018) fix(tip): set significant to 6 for formatting max amount (#6062) fix: ITO history default icon (#6078) feat: add <ConcealableTabs /> (#6073) ...

github-actions Bot temporarily deployed to pull request April 11, 2022 01:59 Inactive

UncleBill force-pushed the feat/pending-tx branch from 1fcb79f to 44f9619 Compare April 11, 2022 01:59

UncleBill changed the title ~~feat: recent transactions~~ feat: manage recent pending transactions Apr 11, 2022

UncleBill force-pushed the feat/pending-tx branch 2 times, most recently from 5461e1d to 1b3ea84 Compare April 11, 2022 02:06

github-actions Bot temporarily deployed to pull request April 11, 2022 02:11 Inactive

github-actions Bot temporarily deployed to pull request April 11, 2022 04:55 Inactive

guanbinrui reviewed Apr 11, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

guanbinrui reviewed Apr 11, 2022

View reviewed changes

UncleBill force-pushed the feat/pending-tx branch 2 times, most recently from 0db471a to 19d9af7 Compare April 12, 2022 02:15

github-actions Bot temporarily deployed to pull request April 12, 2022 02:20 Inactive

guanbinrui added the Test: Pending label Apr 12, 2022

guanbinrui reviewed Apr 12, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

guanbinrui reviewed Apr 12, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

guanbinrui reviewed Apr 12, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

guanbinrui reviewed Apr 12, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

guanbinrui reviewed Apr 12, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

guanbinrui reviewed Apr 12, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

guanbinrui reviewed Apr 12, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/Wallet/hooks/useClearRecentTransactions.ts Outdated

guanbinrui reviewed Apr 12, 2022

View reviewed changes

Comment thread packages/mask/src/plugins/Wallet/hooks/useRemoveRecentTransaction.ts Outdated

github-actions Bot temporarily deployed to pull request April 12, 2022 12:59 Inactive

UncleBill requested a review from guanbinrui April 13, 2022 02:23

guanbinrui reviewed Apr 16, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

guanbinrui reviewed Apr 16, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

github-actions Bot temporarily deployed to pull request April 19, 2022 03:56 Inactive

guanbinrui reviewed Apr 20, 2022

View reviewed changes

Comment thread packages/mask/src/components/shared/WalletStatusBox/TransactionList.tsx Outdated

nuanyang233 reviewed Apr 20, 2022

View reviewed changes

github-actions Bot temporarily deployed to pull request April 20, 2022 04:54 Inactive

UncleBill requested review from guanbinrui and nuanyang233 April 20, 2022 05:16

nuanyang233 reviewed Apr 20, 2022

View reviewed changes

UncleBill added 4 commits April 20, 2022 23:59

feat: recent transactions

9d10585

MF-278

fix: follow up reviews

f141e74

fix: bugs

b6df249

fix: improve useAim

1e9458c

UncleBill force-pushed the feat/pending-tx branch 3 times, most recently from 82b7c6a to c0f77ce Compare April 20, 2022 16:09

github-actions Bot temporarily deployed to pull request April 20, 2022 16:16 Inactive

UncleBill force-pushed the feat/pending-tx branch from c0f77ce to 12446d5 Compare April 21, 2022 01:47

fix: follow up reviews

666a754

UncleBill force-pushed the feat/pending-tx branch from 12446d5 to 666a754 Compare April 21, 2022 01:47

github-actions Bot temporarily deployed to pull request April 21, 2022 01:53 Inactive

UncleBill requested a review from nuanyang233 April 21, 2022 01:54

lelenei approved these changes Apr 21, 2022

View reviewed changes

guanbinrui approved these changes Apr 21, 2022

View reviewed changes

guanbinrui merged commit 1454211 into develop Apr 21, 2022

guanbinrui deleted the feat/pending-tx branch April 21, 2022 01:57

guanbinrui mentioned this pull request Apr 24, 2022

[Release] New release 2.7.0 (minor) #6142

Merged

Uh oh!

Conversation

UncleBill commented Apr 11, 2022

Uh oh!

github-actions Bot commented Apr 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UncleBill commented Apr 12, 2022

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UncleBill commented Apr 14, 2022

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guanbinrui Apr 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nuanyang233 Apr 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Apr 11, 2022 •

edited

Loading

guanbinrui Apr 20, 2022 •

edited

Loading

nuanyang233 Apr 20, 2022 •

edited

Loading