feat: add <ConcealableTabs /> - #6073
Merged
Merged
Conversation
UncleBill
requested review from
guanbinrui,
hanszhoou and
nuanyang233
and removed request for
guanbinrui and
hanszhoou
April 13, 2022 05:41
septs
reviewed
Apr 13, 2022
UncleBill
force-pushed
the
feat/new-tab-style
branch
from
April 13, 2022 05:43
a768c5f to
5a838a7
Compare
septs
reviewed
Apr 13, 2022
UncleBill
force-pushed
the
feat/new-tab-style
branch
5 times, most recently
from
April 13, 2022 05:58
5c75512 to
b34eca2
Compare
Contributor
nuanyang233
reviewed
Apr 13, 2022
guanbinrui
reviewed
Apr 13, 2022
guanbinrui
previously approved these changes
Apr 13, 2022
guanbinrui
changed the title
guanbinrui
previously approved these changes
Apr 15, 2022
Contributor
Author
|
@DimensionDev/qa Please help to verify. |
UncleBill
force-pushed
the
feat/new-tab-style
branch
from
April 18, 2022 02:56
77b1be6 to
cf78de7
Compare
UncleBill
force-pushed
the
feat/new-tab-style
branch
from
April 18, 2022 05:47
cf78de7 to
84bd1a4
Compare
septs
reviewed
Apr 18, 2022
Comment on lines
+152
to
+154
| if (selectedId === undefined && tabs.length) { | ||
| onChange?.(tabs[0].id) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (selectedId === undefined && tabs.length) { | |
| onChange?.(tabs[0].id) | |
| } | |
| if (!selectedId || !tabs?.[0]?.id) return | |
| onChange?.(tabs[0].id) |
septs
reviewed
Apr 18, 2022
| } | ||
| }, [selectedId === undefined, tabs.length > 0, onChange]) | ||
|
|
||
| const slide = useCallback((toLeft: boolean) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| const slide = useCallback((toLeft: boolean) => { | |
| const setSlide = useCallback((toLeft: boolean) => { |
lelenei
approved these changes
Apr 18, 2022
hanszhoou
approved these changes
Apr 18, 2022
yanzhihong23
added a commit
that referenced
this pull request
Apr 24, 2022
* develop: (143 commits) feat: tips entrance (#6012) refactor: remove unused plugin entries chore: patch @solana/web3.js (#6125) New translations en-US.json (Quenya) (#6131) New translations en-US.json (Quenya) (#6126) feat: new intial persona page (#6122) chore: turn on fortmatic (#6127) fix: if phantom is locked, might not able to open its popup (#6115) fix: reduce jsx nested (#6124) fix: duplicate render by unique key (#6123) docs(i18n): sync i18n files from Crowdin (#6119) feat: manage recent pending transactions (#6055) chore: add conflux config (#6112) fix: type error (#6113) feat: improve mask popup (#5986) feat: new app board (#6018) fix(tip): set significant to 6 for formatting max amount (#6062) fix: ITO history default icon (#6078) feat: add <ConcealableTabs /> (#6073) fix: if gulp biuld-ci fails, ci should fail as well (#6107) ...
yanzhihong23
added a commit
that referenced
this pull request
Apr 24, 2022
* develop: (94 commits) fix: mnemonic words exports (#6136) feat: tips entrance (#6012) refactor: remove unused plugin entries chore: patch @solana/web3.js (#6125) New translations en-US.json (Quenya) (#6131) New translations en-US.json (Quenya) (#6126) feat: new intial persona page (#6122) chore: turn on fortmatic (#6127) fix: if phantom is locked, might not able to open its popup (#6115) fix: reduce jsx nested (#6124) fix: duplicate render by unique key (#6123) docs(i18n): sync i18n files from Crowdin (#6119) feat: manage recent pending transactions (#6055) chore: add conflux config (#6112) fix: type error (#6113) feat: improve mask popup (#5986) feat: new app board (#6018) fix(tip): set significant to 6 for formatting max amount (#6062) fix: ITO history default icon (#6078) feat: add <ConcealableTabs /> (#6073) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://mask.atlassian.net/browse/MF-329
Use the tail prop
Scrolling detect
The controllers can auto update