This repository was archived by the owner on Oct 29, 2020. It is now read-only.
creates convertDate helper function and adds field_mobile_app_date to…#4754
Merged
chloealee merged 3 commits intoDoSomethingArchive:devfrom Jul 28, 2015
Merged
creates convertDate helper function and adds field_mobile_app_date to…#4754chloealee merged 3 commits intoDoSomethingArchive:devfrom
chloealee merged 3 commits intoDoSomethingArchive:devfrom
Conversation
Contributor
|
@chloealee looks like this branch needs a rebase against dev! |
… api response for a campaign
Contributor
Author
|
@angaither thanks for that and for sitting with me to rebase! |
Contributor
There was a problem hiding this comment.
I think this line for the $timezone can probably just go inside the dosomething_helpers_convert_date() function :)
Contributor
Author
|
thanks, @weerd ! Updated all the changes we just reviewed together :) |
Contributor
There was a problem hiding this comment.
You can probably consolidate this down to one thing since you're not doing anything else w/ the $mobile_app variable :)
Contributor
|
One small comment, other than that looks great! 👍 |
chloealee
added a commit
that referenced
this pull request
Jul 28, 2015
creates convertDate helper function and adds field_mobile_app_date to…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… api response for a campaign.
Fixes #4723