This repository was archived by the owner on Oct 29, 2020. It is now read-only.
fixes invalid argument in foreach block for mobile app date#4764
Merged
chloealee merged 2 commits intoDoSomethingArchive:devfrom Jul 30, 2015
Merged
fixes invalid argument in foreach block for mobile app date#4764chloealee merged 2 commits intoDoSomethingArchive:devfrom
chloealee merged 2 commits intoDoSomethingArchive:devfrom
Conversation
Contributor
There was a problem hiding this comment.
does if(isset($timing['dates'])` work here, we tend to use that as the standard check
Contributor
There was a problem hiding this comment.
the method @angaither suggests, isset() will actually check if the variable is null or even exists. So it might be possible that the variable might not even exist (which is happening in the bug I'm working on right now), and isset() helps check for both scenarios :)
Contributor
Author
There was a problem hiding this comment.
ahhh got it - way more efficient! Will change it, thank you both!
Contributor
|
Also, can you ref which issue this is fixing |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
chloealee
added a commit
that referenced
this pull request
Jul 30, 2015
fixes invalid argument in foreach block for mobile app date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4754
Fixes #4763