Skip to content

Refactor source output registration in IDE generator#43

Merged
koenbeuk merged 1 commit intomainfrom
feat/gen-implementation-source-output
Apr 25, 2026
Merged

Refactor source output registration in IDE generator#43
koenbeuk merged 1 commit intomainfrom
feat/gen-implementation-source-output

Conversation

@koenbeuk
Copy link
Copy Markdown
Collaborator

Update the source output registration method to use RegisterImplementationSourceOutput instead of RegisterSourceOutput for better performance

Copilot AI review requested due to automatic review settings April 25, 2026 17:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the incremental generator’s source emission registration to use Roslyn’s RegisterImplementationSourceOutput API instead of RegisterSourceOutput, aligning the generator with the intended “implementation output” pipeline and aiming to reduce IDE-time overhead.

Changes:

  • Replaced context.RegisterSourceOutput(...) with context.RegisterImplementationSourceOutput(...) for the [Expressive] pipeline.
  • Replaced context.RegisterSourceOutput(...) with context.RegisterImplementationSourceOutput(...) for the batched [ExpressiveFor*] emission pipeline.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'ExpressiveSharp Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 481b59d Previous: af72c8d Ratio
ExpressiveSharp.Benchmarks.ExpressionResolverBenchmarks.Resolve_Constructor 20.635372799018334 ns (± 12.825022020518675) 7.571761826502866 ns (± 0.032731372760744275) 2.73

This comment was automatically generated by workflow using github-action-benchmark.

@koenbeuk koenbeuk merged commit cc0c346 into main Apr 25, 2026
24 checks passed
@koenbeuk koenbeuk deleted the feat/gen-implementation-source-output branch April 25, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants