Skip to content

Refactor source output registration in IDE generator #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koenbeuk merged 1 commit into from
Apr 25, 2026
+2 −2
Merged

Refactor source output registration in IDE generator #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ExpressiveSharp.Generator/ExpressiveGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
.Combine(context.CompilationProvider)
.WithComparer(new MemberDeclarationSyntaxAndCompilationEqualityComparer());

context.RegisterSourceOutput(compilationAndMemberPairs,
context.RegisterImplementationSourceOutput(compilationAndMemberPairs,
static (spc, source) =>
{
var ((member, attribute, globalOptions), compilation) = source;
Expand Down Expand Up @@ -156,7 +156,7 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
// Collect all items and emit in a single batch to detect duplicates before AddSource.
// Per-item emission would crash the generator on duplicate hint names (Roslyn deduplicates
// after all per-item callbacks, not at the AddSource call site).
context.RegisterSourceOutput(compilationAndPairs.Collect(),
context.RegisterImplementationSourceOutput(compilationAndPairs.Collect(),
static (spc, items) =>
{
var emittedFileNames = new HashSet<string>();
Expand Down
Loading