Skip to content

exit right out when trying to get fx files for OBS#295

Closed
valeriupredoi wants to merge 2 commits into
developmentfrom
development_noFXForOBS
Closed

exit right out when trying to get fx files for OBS#295
valeriupredoi wants to merge 2 commits into
developmentfrom
development_noFXForOBS

Conversation

@valeriupredoi

Copy link
Copy Markdown
Contributor

Addresses the issue with OBS datasets not having fx files (well, at least most of them) and reported in #294

CAVEAT this is a guillotine treatment that is not sensitive to the OBS datasets that may have fx files and should also be always used with always_use_ne_mask: True as arg in the masking preprocessor

Up for discussion 💾

@valeriupredoi valeriupredoi added bug Something isn't working preprocessor Related to the preprocessor labels Oct 7, 2019
@valeriupredoi

Copy link
Copy Markdown
Contributor Author

@mattiarighi @hb326 @rswamina you guys have a ton of experience with OBSes - which ones have fx data? If none then we can safely leave the cut-throat approach from here, if otherwise we need to plug in something more fancy 🍺

Comment thread esmvalcore/_recipe.py Outdated
@mattiarighi

Copy link
Copy Markdown
Contributor

At the moment only ERA-Interim and NSIDC-0116.
But other ones are coming, e.g. #1042.

Co-Authored-By: bascrezee <bascrezee@gmail.com>
@valeriupredoi

Copy link
Copy Markdown
Contributor Author

At the moment only ERA-Interim and NSIDC-0116.
But other ones are coming, e.g. #1042.

damn! thought I might get out easy 😁 OK we need a dedicated issue for that then

@valeriupredoi

Copy link
Copy Markdown
Contributor Author

let's plug this in for now so we have a somewhat decent functionality and then concern about the others later

@valeriupredoi

Copy link
Copy Markdown
Contributor Author

#297 supersedes this so am gonna close w/o merge

@valeriupredoi valeriupredoi deleted the development_noFXForOBS branch October 7, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working preprocessor Related to the preprocessor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants