exit right out when trying to get fx files for OBS#295
Closed
valeriupredoi wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@mattiarighi @hb326 @rswamina you guys have a ton of experience with OBSes - which ones have fx data? If none then we can safely leave the cut-throat approach from here, if otherwise we need to plug in something more fancy 🍺 |
bascrezee
reviewed
Oct 7, 2019
Contributor
|
At the moment only |
Co-Authored-By: bascrezee <bascrezee@gmail.com>
Contributor
Author
damn! thought I might get out easy 😁 OK we need a dedicated issue for that then |
Contributor
Author
|
let's plug this in for now so we have a somewhat decent functionality and then concern about the others later |
Contributor
Author
|
#297 supersedes this so am gonna close w/o merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the issue with OBS datasets not having fx files (well, at least most of them) and reported in #294
CAVEAT this is a guillotine treatment that is not sensitive to the OBS datasets that may have fx files and should also be always used with
always_use_ne_mask: Trueas arg in the masking preprocessorUp for discussion 💾