Find various fx files for OBS projects for preprocessor masking#297
Merged
Conversation
Co-Authored-By: bascrezee <bascrezee@gmail.com>
Contributor
Author
|
OK tested with ERA-Interim files, works fine! Can someone pls test 🍺 |
This was referenced Oct 7, 2019
Contributor
Author
|
tested with #210 (ie with stock OBS fx file names and all the rest of that PR) and it works a-ok 🍺 |
Contributor
Author
|
@mattiarighi since you are at ESMValGroup/ESMValTool#1310 maybe you can test this one real quick in conjunction with those tests and approve pls? ❤️ |
Contributor
|
That's what I'm doing right now 🍺 |
Contributor
Author
you are a sweetpea 🥇 |
Contributor
|
Tested as part of #1310, seems to work as expected. |
Contributor
Author
|
Noice! When you gots time, could you pls throw in some OBS's that have fx
data? I tested with ERA, but not with others. Should do the job ok either
way 🍺
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Thu, 10 Oct 2019, 09:11 Mattia Righi, ***@***.***> wrote:
Tested as part of #1310
<ESMValGroup/ESMValTool#1310>, seems to work as
expected.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#297?email_source=notifications&email_token=AG5EFI3G6IM5CH6A3NN73NLQN3PSTA5CNFSM4I6FNZ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA3KTMI#issuecomment-540453297>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG5EFI6R4O6VTL72XTMKNF3QN3PSTANCNFSM4I6FNZ7Q>
.
|
Contributor
|
I can do that with |
Contributor
Author
|
You the bestest 🍺
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Thu, 10 Oct 2019, 09:26 Mattia Righi, ***@***.***> wrote:
I can do that with NSIDC and PIOMAS.
Will do once done with the branch by Ruth.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#297?email_source=notifications&email_token=AG5EFI6UU4EXVYRALSSLYMTQN3RLPA5CNFSM4I6FNZ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA3MBHI#issuecomment-540459165>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG5EFI7V7MYKX6E3WOTWSETQN3RLPANCNFSM4I6FNZ7Q>
.
|
Contributor
Contributor
Author
|
Yes, I tested it with an hoc merge of #210, works fine, it is idependent of
that PR so merging can happen at any time, no conflicts either
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Thu, 10 Oct 2019, 13:34 Mattia Righi, ***@***.***> wrote:
This should be tested together with #1272
<ESMValGroup/ESMValTool#1272>, which itself needs
#210 <#210>. Right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#297?email_source=notifications&email_token=AG5EFI46AJD5VXMNIO4TBGDQN4OORA5CNFSM4I6FNZ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA4CSFI#issuecomment-540551445>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG5EFI7MI3LSIJVF7QZSKPLQN4OORANCNFSM4I6FNZ7Q>
.
|
Contributor
|
Actually if you use the |
Contributor
Author
|
Hmmm, yes, but who uses that 😁
Dr Valeriu Predoi.
Computational scientist
NCAS-CMS
University of Reading
Department of Meteorology
Reading RG6 6BB
United Kingdom
…On Thu, 10 Oct 2019, 14:17 Mattia Righi, ***@***.***> wrote:
Actually if you use the default drs for OBS that PR is quite important.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#297?email_source=notifications&email_token=AG5EFI5C56DDEZ2VLDEI6JLQN4TQLA5CNFSM4I6FNZ72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA4IN6Q#issuecomment-540575482>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG5EFIZ2ZKAFTIR2W2TRMWTQN4TQLANCNFSM4I6FNZ7Q>
.
|
Contributor
mattiarighi
approved these changes
Oct 10, 2019
Contributor
Author
|
push, push, push 🚼 |
Contributor
|
@bascrezee did you already test this? |
Contributor
|
Yes, I just tested and it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should solve #296