Added various fixes for hybrid pressure coordinates#529
Merged
Conversation
cc2e09c to
9c0abdf
Compare
This was referenced Mar 3, 2020
Closed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f0643c1 to
0dfb43c
Compare
This comment has been minimized.
This comment has been minimized.
zklaus
reviewed
Mar 11, 2020
zklaus
left a comment
There was a problem hiding this comment.
Left some comments, did not review the tests yet.
9 tasks
zklaus
reviewed
Mar 12, 2020
0dfb43c to
8b10380
Compare
Contributor
Author
|
@zklaus I rebased the master and added your suggestions. Please not that I intentionally did not use from ..common import ClFixHybridPressureCoord as Clbut from ..common import ClFixHybridPressureCoord
Cl = ClFixHybridPressureCoordfor two reasons: First, to mute Codacy and second, to make it clearer that there is a fix for |
zklaus
approved these changes
Mar 12, 2020
zklaus
left a comment
There was a problem hiding this comment.
I didn't check all tests in detail, but to me it seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added various fixes for CMIP5 and CMIP6 models concerning hybrid pressure coordinates (variables
cl,cliandclw).Tasks
yamllintto check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Related to #536, #540, #541, #542. (Note: Automatic closing of these issues is not desired; they should be closed when the issue is reported to the modelers).