Skip to content

Added fixes for tos of BCC models#560

Merged
mattiarighi merged 2 commits into
masterfrom
bcc_fixes
Mar 12, 2020
Merged

Added fixes for tos of BCC models#560
mattiarighi merged 2 commits into
masterfrom
bcc_fixes

Conversation

@schlunma

@schlunma schlunma commented Mar 9, 2020

Copy link
Copy Markdown
Contributor

This PR adds fixes for tos of the CMIP6 BCC models

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Related to #537. (Note: Automatic closing of these issues is not desired; they should be closed when the issue is reported to the modelers).

@schlunma schlunma added the fix for dataset Related to dataset-specific fix files label Mar 9, 2020
@schlunma schlunma requested review from valeriupredoi and zklaus March 9, 2020 13:45
@schlunma schlunma self-assigned this Mar 9, 2020
@schlunma schlunma added this to the ESMValTool papers milestone Mar 10, 2020
@schlunma schlunma mentioned this pull request Mar 11, 2020
@mattiarighi mattiarighi merged commit 2775c43 into master Mar 12, 2020
@mattiarighi mattiarighi deleted the bcc_fixes branch March 12, 2020 07:36
@npgillett

Copy link
Copy Markdown
Contributor

@schlunma This fix should also be applied to siconc - I got the same error as above for tos, when I tried to process siconc from BCC-CSM2-MR. This was also raised in #151. Thanks...

@schlunma

schlunma commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

This probably needs to be applied to many ocean variables. Unfortunately, I did/do not have the resources to check all of them, but you can simply use this line as a template on how to easily apply an already present fix to another variable (an another model if necessary). In your case this would be something like Siconc = BaseTos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix for dataset Related to dataset-specific fix files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants