Skip to content

feat(automode): held-PR pipeline 3a — verifier gate + per-slice landing#29

Merged
Ecko95 merged 8 commits into
gitsfrom
feat/automode-held-pr-pipeline
Jun 20, 2026
Merged

feat(automode): held-PR pipeline 3a — verifier gate + per-slice landing#29
Ecko95 merged 8 commits into
gitsfrom
feat/automode-held-pr-pipeline

Conversation

@Ecko95

@Ecko95 Ecko95 commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Plan 3a of the autonomous-toggle roadmap (Plan 3 split into 3a gate+landing / 3b held-PR+merge-detect). Plan: docs/superpowers/plans/2026-06-20-automode-held-pr-3a-gate-landing.md.

What this does

Replaces the AutomodeDriver's bare completeGoal on a done peer with gate → land → complete:

  1. Run GitsReviewPipeline.review over the done peer's worktree (mechanical suite + semantic verifier).
  2. Pass → fast-forward the verified slice onto the per-repo integration branch auto/<id> (chain-advance), then complete the goal. Fail → fail the goal + halt. Non-fast-forward landing → halt. uncertain verdict lands but is flagged.
  3. Dispatch now spawns peers from the integration tip (startRef) to a per-slice branch (auto/slice/<goalId>) so landing is a fast-forward.

Fail-closed: no integration branch / empty verificationCommands / missing peer worktree → halt, never land unverified work.

Design decisions (2026-06-20 checkpoint)

  • Verifier runs criteria-less (sliceId = goal.id, no per-slice acceptance criteria); the criteria importer is Plan 7.
  • verificationCommands + integrationBranch are new AutomodePolicy fields, supplied at arm time.
  • Held PR to gits + patch-id merge detection are Plan 3b (not in this PR).

New surfaces

  • contracts: AutomodePolicy.verificationCommands + integrationBranch (back-compat via withDecodingDefault).
  • AutomodeReviewGate.ts (pure gate decision), AutomodeLandingCommands.ts (pure git-argv), AutomodeLanding service (ensure-branch + FF-push via GitVcsDriver.execute).

Verification

  • 114 tests across all touched files pass; full repo typecheck green (tsgo --force, 14/14); lint 0 errors.
  • Pre-existing flaky test unrelated to this change: ProviderRegistry > re-probes when settings change the codex binaryPath (time-based, passes 33/33 in isolation).

🤖 Generated with Claude Code

Ecko95 and others added 8 commits June 20, 2026 14:42
…ation plan

Plan 3 of the autonomous-toggle roadmap, split 3a (gate+landing) / 3b
(held-PR + patch-id merge detection). 3a: gate completed peers through
GitsReviewPipeline and fast-forward verified slices onto the per-repo
integration branch. Design decisions locked at the 2026-06-20 checkpoint:
criteria-less verifier (Plan 7 adds the importer), verificationCommands as
a new AutomodePolicy field, 3a/3b split.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant