Skip to content

feat(automode): held-PR pipeline 3a — verifier gate + per-slice landing #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ecko95 merged 8 commits into from
Jun 20, 2026
Merged

feat(automode): held-PR pipeline 3a — verifier gate + per-slice landing #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7700d50
docs(automode): Plan 3a — verifier gate + per-slice landing implement…
Ecko95 Jun 20, 2026
faca98c
feat(contracts): automode policy verificationCommands + integrationBr…
Ecko95 Jun 20, 2026
ad17c09
feat(automode): persist verificationCommands + integrationBranch; dis…
Ecko95 Jun 20, 2026
2756c90
test(server): add new automode policy fields to snapshot fixture
Ecko95 Jun 20, 2026
4963ad5
feat(automode): pure verifier-gate decision
Ecko95 Jun 20, 2026
38b61ef
feat(automode): pure git-argv builders for slice landing
Ecko95 Jun 20, 2026
51030a6
feat(automode): AutomodeLanding service (ensure branch + FF-push slice)
Ecko95 Jun 20, 2026
e0f43e9
feat(automode): gate completed peers and land verified slices onto in…
Ecko95 Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
568 changes: 361 additions & 207 deletions apps/server/src/gits/Layers/AutomodeDriver.test.ts
View file
Open in desktop

Large diffs are not rendered by default.

295 changes: 181 additions & 114 deletions apps/server/src/gits/Layers/AutomodeDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,133 +2,200 @@ import * as Duration from "effect/Duration";
import * as Effect from "effect/Effect";
import * as Layer from "effect/Layer";

import type { AutomodeGoal, PeerStatus } from "@t3tools/contracts";
import { AutomodeSupervisorError, type AutomodeGoal, type PeerStatus } from "@t3tools/contracts";

import { DelamainAdapter } from "../Services/DelamainAdapter.ts";
import { AutomodeSupervisor } from "../Services/AutomodeSupervisor.ts";
import { AutomodeDriver, type AutomodeDriverShape } from "../Services/AutomodeDriver.ts";
import { GitsReviewPipeline } from "../Services/GitsReviewPipeline.ts";
import { AutomodeLanding } from "../Services/AutomodeLanding.ts";
import { decide_automode_gate } from "./AutomodeReviewGate.ts";

const TICK_INTERVAL_MS = (() => {
const raw = process.env.GITS_AUTOMODE_DRIVER_TICK_MS?.trim();
const parsed = raw === undefined || raw === "" ? Number.NaN : Number.parseInt(raw, 10);
return Number.isFinite(parsed) && parsed > 0 ? parsed : 5000;
const raw = process.env.GITS_AUTOMODE_DRIVER_TICK_MS?.trim();
const parsed = raw === undefined || raw === "" ? Number.NaN : Number.parseInt(raw, 10);
return Number.isFinite(parsed) && parsed > 0 ? parsed : 5000;
})();

const TERMINAL_FAIL_STATUSES = new Set<PeerStatus>(["failed", "frozen", "killed", "halted"]);
const TERMINAL_DONE_STATUSES = new Set<PeerStatus>(["done", "completed"]);

function oldestQueued(goals: ReadonlyArray<AutomodeGoal>): AutomodeGoal | null {
// The snapshot sorts goals newest-first; reverse before sorting so that
// equal-timestamp goals remain in oldest-first (FIFO) order.
const queued = [...goals]
.reverse()
.filter((goal) => goal.status === "queued")
.sort((left, right) => left.createdAt.localeCompare(right.createdAt));
return queued[0] ?? null;
// The snapshot sorts goals newest-first; reverse before sorting so that
// equal-timestamp goals remain in oldest-first (FIFO) order.
const queued = [...goals]
.reverse()
.filter((goal) => goal.status === "queued")
.sort((left, right) => left.createdAt.localeCompare(right.createdAt));
return queued[0] ?? null;
}

export const AutomodeDriverLive = Layer.effect(
AutomodeDriver,
Effect.gen(function* () {
const supervisor = yield* AutomodeSupervisor;
const delamainAdapter = yield* DelamainAdapter;

const tickOnce: AutomodeDriverShape["tickOnce"] = () =>
Effect.gen(function* () {
const snapshot = yield* supervisor.getSnapshot();

// Only act in autonomous mode with the kill switch off.
if (snapshot.policy.mode !== "autonomous" || snapshot.policy.killSwitchEnabled) {
return;
}

// 1) Reconcile the in-flight goal (sequential: at most one running).
const running = snapshot.goals.find(
(goal) => goal.status === "running" && goal.peerId !== null,
);
if (running !== undefined) {
const peers = yield* delamainAdapter.listPeers().pipe(
Effect.map((result) => result.peers),
Effect.catch(() => Effect.succeed([])),
);
const peer = peers.find((candidate) => candidate.id === running.peerId);
if (peer === undefined) {
// The in-flight peer vanished from delamain (reaped or crashed after
// finishing). A silent return would leave this goal stuck "running"
// forever and deadlock the whole queue invisibly, so halt loudly and
// let an operator resume if it was transient.
yield* supervisor.haltDriver({
reason: `Halted: peer ${running.peerId} for "${running.title}" not found in delamain (vanished or reaped) — manual check needed.`,
});
return;
}

if (peer.integrationStatus === "failed" || TERMINAL_FAIL_STATUSES.has(peer.status)) {
yield* supervisor.failGoal({
goalId: running.id,
reason: `Peer ${peer.id} ended as ${peer.status}.`,
});
yield* supervisor.haltDriver({
reason: `Halted: ${running.title} failed (${peer.status}).`,
});
return;
}
if (peer.status === "waiting") {
yield* supervisor.haltDriver({
reason: `Halted: peer ${peer.id} is waiting on input for ${running.title}.`,
});
return;
}
if (TERMINAL_DONE_STATUSES.has(peer.status)) {
yield* supervisor.completeGoal({ goalId: running.id });
yield* Effect.logInfo("gits.automode.driver.goal-completed", {
goalId: running.id,
peerId: peer.id,
});
return;
}
return; // pending / running / blocked → still in flight
}

// 2) Idle: if halted, wait for an operator resume.
if (snapshot.driverHalted) {
return;
}

// 3) Dispatch the oldest queued goal (sequential start).
const next = oldestQueued(snapshot.goals);
if (next === null) {
return;
}
const result = yield* supervisor.dispatchGoal({ goalId: next.id });
if (result.peer === null) {
yield* supervisor.haltDriver({
reason: result.blockedReason ?? `Dispatch of ${next.title} did not spawn a peer.`,
});
}
});

// Forked, scoped polling fiber — runs for the lifetime of the layer.
// Sleep first so that tests can call tickOnce() directly without
// the background fiber racing on the first iteration.
yield* Effect.forever(
Effect.sleep(Duration.millis(TICK_INTERVAL_MS)).pipe(
Effect.andThen(tickOnce()),
// Mirror ProviderSessionReaper: recover ONLY from typed failures and
// defects, never from interruption. catch/catchDefect both leave
// interruption untouched, so a scope-close/shutdown interrupt tears the
// loop down cleanly instead of being swallowed and restarting forever.
Effect.catch((error) =>
Effect.logWarning("gits.automode.driver.tick-failed", { error: error.message }),
),
Effect.catchDefect((defect) =>
Effect.logWarning("gits.automode.driver.tick-defect", { defect }),
),
),
).pipe(Effect.forkScoped);

yield* Effect.logInfo("gits.automode.driver.started", { tickIntervalMs: TICK_INTERVAL_MS });

return { tickOnce } satisfies AutomodeDriverShape;
}),
AutomodeDriver,
Effect.gen(function* () {
const supervisor = yield* AutomodeSupervisor;
const delamainAdapter = yield* DelamainAdapter;
const reviewPipeline = yield* GitsReviewPipeline;
const landing = yield* AutomodeLanding;

const tickOnce: AutomodeDriverShape["tickOnce"] = () =>
Effect.gen(function* () {
const snapshot = yield* supervisor.getSnapshot();

// Only act in autonomous mode with the kill switch off.
if (snapshot.policy.mode !== "autonomous" || snapshot.policy.killSwitchEnabled) {
return;
}

// 1) Reconcile the in-flight goal (sequential: at most one running).
const running = snapshot.goals.find(
(goal) => goal.status === "running" && goal.peerId !== null,
);
if (running !== undefined) {
const peers = yield* delamainAdapter.listPeers().pipe(
Effect.map((result) => result.peers),
Effect.catch(() => Effect.succeed([])),
);
const peer = peers.find((candidate) => candidate.id === running.peerId);
if (peer === undefined) {
// The in-flight peer vanished from delamain (reaped or crashed after
// finishing). A silent return would leave this goal stuck "running"
// forever and deadlock the whole queue invisibly, so halt loudly and
// let an operator resume if it was transient.
yield* supervisor.haltDriver({
reason: `Halted: peer ${running.peerId} for "${running.title}" not found in delamain (vanished or reaped) — manual check needed.`,
});
return;
}

if (peer.integrationStatus === "failed" || TERMINAL_FAIL_STATUSES.has(peer.status)) {
yield* supervisor.failGoal({
goalId: running.id,
reason: `Peer ${peer.id} ended as ${peer.status}.`,
});
yield* supervisor.haltDriver({
reason: `Halted: ${running.title} failed (${peer.status}).`,
});
return;
}
if (peer.status === "waiting") {
yield* supervisor.haltDriver({
reason: `Halted: peer ${peer.id} is waiting on input for ${running.title}.`,
});
return;
}
if (TERMINAL_DONE_STATUSES.has(peer.status)) {
const policy = snapshot.policy;

// Fail closed: never land unverified work, and never land without a target.
if (policy.integrationBranch === null) {
yield* supervisor.haltDriver({
reason: `Halted: ${running.title} finished but no integration branch is configured.`,
});
return;
}
if (policy.verificationCommands.length === 0) {
yield* supervisor.haltDriver({
reason: `Halted: ${running.title} finished but no verification commands are configured.`,
});
return;
}
if (peer.worktreePath === null || peer.branch === null) {
yield* supervisor.haltDriver({
reason: `Halted: peer ${peer.id} has no worktree/branch to verify and land.`,
});
return;
}

const review = yield* reviewPipeline
.review({
worktree: peer.worktreePath,
baseRef: policy.integrationBranch,
sliceId: running.id,
verificationCommands: policy.verificationCommands,
})
.pipe(
Effect.mapError(
(cause) =>
new AutomodeSupervisorError({
message: `Verifier failed for ${running.title}.`,
cause,
}),
),
);

const decision = decide_automode_gate(review);
if (decision.action === "fail") {
yield* supervisor.failGoal({ goalId: running.id, reason: decision.reason });
yield* supervisor.haltDriver({
reason: `Halted: ${running.title} failed review — ${decision.reason}`,
});
return;
}

const landResult = yield* landing.land_slice({
repo: running.repo,
integrationBranch: policy.integrationBranch,
baseRef: "gits",
sliceBranch: peer.branch,
});
if (landResult.status === "rejected") {
yield* supervisor.haltDriver({
reason: `Halted: ${running.title} passed review but could not land — ${landResult.reason}`,
});
return;
}

yield* supervisor.completeGoal({ goalId: running.id });
yield* Effect.logInfo("gits.automode.driver.goal-landed", {
goalId: running.id,
peerId: peer.id,
flagged: decision.flagged,
});
return;
}
return; // pending / running / blocked → still in flight
}

// 2) Idle: if halted, wait for an operator resume.
if (snapshot.driverHalted) {
return;
}

// 3) Dispatch the oldest queued goal (sequential start).
const next = oldestQueued(snapshot.goals);
if (next === null) {
return;
}
const result = yield* supervisor.dispatchGoal({ goalId: next.id });
if (result.peer === null) {
yield* supervisor.haltDriver({
reason: result.blockedReason ?? `Dispatch of ${next.title} did not spawn a peer.`,
});
}
});

// Forked, scoped polling fiber — runs for the lifetime of the layer.
// Sleep first so that tests can call tickOnce() directly without
// the background fiber racing on the first iteration.
yield* Effect.forever(
Effect.sleep(Duration.millis(TICK_INTERVAL_MS)).pipe(
Effect.andThen(tickOnce()),
// Mirror ProviderSessionReaper: recover ONLY from typed failures and
// defects, never from interruption. catch/catchDefect both leave
// interruption untouched, so a scope-close/shutdown interrupt tears the
// loop down cleanly instead of being swallowed and restarting forever.
Effect.catch((error) =>
Effect.logWarning("gits.automode.driver.tick-failed", { error: error.message }),
),
Effect.catchDefect((defect) =>
Effect.logWarning("gits.automode.driver.tick-defect", { defect }),
),
),
).pipe(Effect.forkScoped);

yield* Effect.logInfo("gits.automode.driver.started", { tickIntervalMs: TICK_INTERVAL_MS });

return { tickOnce } satisfies AutomodeDriverShape;
}),
);
Loading